From: Chris Wright <chrisw@sous-sol.org>
To: Chris Wright <chrisw@sous-sol.org>,
David Miller <davem@davemloft.net>,
linux-fbdev@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms
Date: Thu, 3 Mar 2011 15:53:05 -0800 [thread overview]
Message-ID: <20110303235305.GY4988@sequoia.sous-sol.org> (raw)
In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit>
* Lars Ellenberg (lars.ellenberg@linbit.com) wrote:
> Last time I checked, current() for connector based netlink message
> consumers was the work queue that is used for connector.
>
> So unless that changed, or my understanding is wrong, current_cap()
> inside cn_queue_wrapper(), respectively the d->callback()
> will not be the userland sender process' capabilities, but the work
> queue capabilities.
Yes, you're right.
> If so, then this change introduces the possibility for normal users to
> send privileged commands to connector based subsystems, even if they
> may not be able to bind() to suitable sockets to receive any replies.
>
> Am I missing something?
No, thanks for review. This puts back the async issue.
next prev parent reply other threads:[~2011-03-03 23:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 9:38 [PATCH 2/2] netlink: kill eff_cap from struct netlink_skb_parms Patrick McHardy
2011-03-03 10:49 ` James Morris
2011-03-03 17:32 ` Chris Wright
2011-03-03 18:56 ` David Miller
2011-03-03 20:15 ` [PATCH 2/2 v2] " Chris Wright
2011-03-03 21:39 ` David Miller
[not found] ` <20110303201522.GT4988-JyIX8gxvWYPr2PDY2+4mTGD2FQJk+8+b@public.gmane.org>
2011-03-03 22:37 ` Lars Ellenberg
2011-03-03 23:53 ` Chris Wright [this message]
2011-03-04 1:29 ` [Drbd-dev] " Evgeniy Polyakov
2011-03-04 1:38 ` David Miller
2011-03-08 14:50 ` Patrick McHardy
2011-03-08 18:32 ` Evgeniy Polyakov
2011-03-08 18:54 ` Patrick McHardy
2011-03-17 15:43 ` Evgeniy Polyakov
2011-03-03 20:17 ` [PATCH 2/2] " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303235305.GY4988@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox