dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: christophe.varoqui@opensvc.com,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: multipath: add find_multipaths feature.
Date: Thu, 14 Jul 2011 20:53:03 -0400	[thread overview]
Message-ID: <20110715005302.GA26472@redhat.com> (raw)
In-Reply-To: <1291762849.4430.6.camel@zezette>

On Tue, Dec 07 2010 at  6:00pm -0500,
Christophe Varoqui <christophe.varoqui@gmail.com> wrote:

> On mar., 2010-11-16 at 17:25 -0600, Benjamin Marzinski wrote:
> > This adds a new default feature, find_multipaths. When this is set to yes,
> > multipath will no longer try to create multipath devices using every
> > non-blacklisted device. Instead, it will only create a device when one of
> > three conditions are met.
> > 
> > 1. Three are at least two non-blacklisted paths with the same wwid
> > 2. The user manually forces the creation, by specifying a device with the
> >    multipath command.
> > 3. A path has the same wwid as a multipath device that was previously crreated
> >    (even if that multipath device doesn't currently exist).
> > 
> > To do 3, multipath stores the wwid of every path that it creates in
> > /etc/multipath/wwids. Whenever a path is added, its wwid is checked against
> > this file.  If there's a match, it is multipathed, even if it's the only path.
> > This should allow multipath to automatically choose the correct paths to make
> > into multipath devics in most cases, without needing the user to edit the
> > blacklist.
> > 
> Hi Ben,
> 
> I just merged the patches you queued for upstream the last weeks, except
> this one. I'm still not convinced, but that may be because I have not
> understood yet. I'll try and give it more brain.

find_multipaths is quite useful for avoiding the issue that was just
reported where multipath grabs the root device even though it doesn't
have multiple paths.

Any chance you could reevaluate Ben's patch for inclusion?

  reply	other threads:[~2011-07-15  0:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 23:25 [PATCH] multipath: add find_multipaths feature Benjamin Marzinski
2010-11-16 23:51 ` Christophe Varoqui
2010-11-18 17:21   ` Benjamin Marzinski
2010-12-07 23:00 ` Christophe Varoqui
2011-07-15  0:53   ` Mike Snitzer [this message]
2011-07-15  7:03     ` Christophe Varoqui
2011-07-18 10:01     ` Peter Volkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110715005302.GA26472@redhat.com \
    --to=snitzer@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).