From: Benjamin Marzinski <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: [PATCH] multipath: get right sysfs value for checker_timeout
Date: Tue, 4 Oct 2011 23:15:05 -0500 [thread overview]
Message-ID: <20111005041505.GQ24133@ether.msp.redhat.com> (raw)
sysfs_get_timeout() wasn't looking in the correct directory for the
checker timeout value. It was looking at .../block/<devname>/timeout,
instead of .../block/<devname>/device/timeout
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: multipath-tools-110916/libmultipath/discovery.c
===================================================================
--- multipath-tools-110916.orig/libmultipath/discovery.c
+++ multipath-tools-110916/libmultipath/discovery.c
@@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
if (safe_sprintf(attr_path, "%s/device", dev->devpath))
return 1;
- len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
+ len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
if (!len) {
condlog(3, "%s: No timeout value in sysfs", dev->devpath);
return 1;
next reply other threads:[~2011-10-05 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 4:15 Benjamin Marzinski [this message]
2011-10-05 20:45 ` [PATCH] multipath: get right sysfs value for checker_timeout Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005041505.GQ24133@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox