* [PATCH] multipath: don't print so many add map messages
@ 2011-11-12 5:12 Benjamin Marzinski
2011-11-12 10:17 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2011-11-12 5:12 UTC (permalink / raw)
To: device-mapper development; +Cc: Christophe Varoqui
Whenever a dm device gets a change uevent, multipathd prints an add map
message. This can get confusing for users, so change that message to
not print at the default log level, and add a new message that only
prints if multipathd will actually try to add a map
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
multipathd/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: multipath-tools-111111/multipathd/main.c
===================================================================
--- multipath-tools-111111.orig/multipathd/main.c
+++ multipath-tools-111111/multipathd/main.c
@@ -232,7 +232,7 @@ uev_add_map (struct uevent * uev, struct
char *alias;
int major = -1, minor = -1, rc;
- condlog(2, "%s: add map (uevent)", uev->kernel);
+ condlog(3, "%s: add map (uevent)", uev->kernel);
alias = uevent_get_dm_name(uev);
if (!alias) {
condlog(3, "%s: No DM_NAME in uevent", uev->kernel);
@@ -280,6 +280,7 @@ ev_add_map (char * dev, char * alias, st
}
return 0;
}
+ condlog(2, "%s: adding map", alias);
/*
* now we can register the map
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] multipath: don't print so many add map messages
2011-11-12 5:12 [PATCH] multipath: don't print so many add map messages Benjamin Marzinski
@ 2011-11-12 10:17 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2011-11-12 10:17 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development
On ven., 2011-11-11 at 23:12 -0600, Benjamin Marzinski wrote:
> Whenever a dm device gets a change uevent, multipathd prints an add map
> message. This can get confusing for users, so change that message to
> not print at the default log level, and add a new message that only
> prints if multipathd will actually try to add a map
>
Applied.
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> multipathd/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: multipath-tools-111111/multipathd/main.c
> ===================================================================
> --- multipath-tools-111111.orig/multipathd/main.c
> +++ multipath-tools-111111/multipathd/main.c
> @@ -232,7 +232,7 @@ uev_add_map (struct uevent * uev, struct
> char *alias;
> int major = -1, minor = -1, rc;
>
> - condlog(2, "%s: add map (uevent)", uev->kernel);
> + condlog(3, "%s: add map (uevent)", uev->kernel);
> alias = uevent_get_dm_name(uev);
> if (!alias) {
> condlog(3, "%s: No DM_NAME in uevent", uev->kernel);
> @@ -280,6 +280,7 @@ ev_add_map (char * dev, char * alias, st
> }
> return 0;
> }
> + condlog(2, "%s: adding map", alias);
>
> /*
> * now we can register the map
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-12 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-12 5:12 [PATCH] multipath: don't print so many add map messages Benjamin Marzinski
2011-11-12 10:17 ` Christophe Varoqui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).