dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: 648367@bugs.debian.org, dm-devel@redhat.com
Subject: Bug#648367: device-mapper devices such as dm-crypt always have rotational=1; should inherit "rotational" setting from underlying devices
Date: Sun, 13 Nov 2011 18:26:44 -0800	[thread overview]
Message-ID: <20111114022644.GB30421@leaf> (raw)
In-Reply-To: <1321232729.3059.42.camel@deadeye>

On Mon, Nov 14, 2011 at 01:05:29AM +0000, Ben Hutchings wrote:
> On Thu, 2011-11-10 at 11:59 -0800, Josh Triplett wrote:
> > Source: linux-2.6
> > Version: 3.1.0-1~experimental.1
> > Severity: normal
> > 
> > I use dm-crypt on my system, and I have an SSD.  The underlying disk
> > device, sda, has rotational=0:
> > 
> > ~$ cat /sys/block/sda/queue/rotational
> > 0
> > 
> > However, the device-mapper devices have rotational=1:
> > 
> > ~$ head /sys/block/dm-*/queue/rotational
> > ==> /sys/block/dm-0/queue/rotational <==
> > 1
> > 
> > ==> /sys/block/dm-1/queue/rotational <==
> > 1
> > 
> > ==> /sys/block/dm-2/queue/rotational <==
> > 1
> > 
> > The device-mapper devices should inherit the setting for "rotational"
> > from their underlying devices.
> 
> I'm not sure that's true.  Since their queues should feed into the
> queues for the underlying devices, it may be that they shouldn't
> themselves be scheduled as if they are rotating media.

OK, I suppose I don't actually care what rotational shows for a
device-mapper device backed by rotating media.  The case I care about:
when the underlying media has rotational=0, the dm device definitely
shouldn't have rotational=1.

- Josh Triplett

  reply	other threads:[~2011-11-14  2:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111110195943.12083.93273.reportbug@leaf>
2011-11-14  1:05 ` Bug#648367: device-mapper devices such as dm-crypt always have rotational=1; should inherit "rotational" setting from underlying devices Ben Hutchings
2011-11-14  2:26   ` Josh Triplett [this message]
2011-11-15  7:34     ` Milan Broz
2011-11-15 16:41       ` Bug#648367: [dm-devel] " Josh Triplett
2011-11-15 17:05         ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114022644.GB30421@leaf \
    --to=josh@joshtriplett.org \
    --cc=648367@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).