* [Bcache v14 PATCH] fix compiler error
[not found] <1abe2159-2201-46c4-9c60-afc4f358ff6a@mail.eladian.com>
@ 2012-07-19 20:53 ` Daniel Wisehart
2012-07-23 21:12 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Wisehart @ 2012-07-19 20:53 UTC (permalink / raw)
To: linux-kernel; +Cc: dm-devel
Hello Kent,
This patch keeps gcc 4.7.0 happy. The static function dump_bset() could be moved, but that would have made a bigger patch. :-)
Thanks,
Daniel
diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
index 3c9c24d..4dc0ba5 100644
--- a/drivers/md/bcache/debug.c
+++ b/drivers/md/bcache/debug.c
@@ -83,6 +83,8 @@ struct keyprint_hack bch_pbtree(const struct btree *b)
#ifdef CONFIG_BCACHE_DEBUG
+static void dump_bset(struct btree *b, struct bset *i);
+
void bch_btree_verify(struct btree *b, struct bset *new)
{
struct btree *v = b->c->verify_data;
This communication is restricted - please see http://www.eladian.com for further information.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Bcache v14 PATCH] fix compiler error
2012-07-19 20:53 ` [Bcache v14 PATCH] fix compiler error Daniel Wisehart
@ 2012-07-23 21:12 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2012-07-23 21:12 UTC (permalink / raw)
To: Daniel Wisehart; +Cc: linux-kernel, dm-devel
On Thu, Jul 19, 2012 at 04:53:26PM -0400, Daniel Wisehart wrote:
> Hello Kent,
>
> This patch keeps gcc 4.7.0 happy. The static function dump_bset() could be moved, but that would have made a bigger patch. :-)
Thanks! dump_bset() does need to be moved so it's available if DEBUG or
EDEBUG are on, but thanks for pointing it out :)
>
> Thanks,
> Daniel
>
>
>
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index 3c9c24d..4dc0ba5 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -83,6 +83,8 @@ struct keyprint_hack bch_pbtree(const struct btree *b)
>
> #ifdef CONFIG_BCACHE_DEBUG
>
> +static void dump_bset(struct btree *b, struct bset *i);
> +
> void bch_btree_verify(struct btree *b, struct bset *new)
> {
> struct btree *v = b->c->verify_data;
>
>
> This communication is restricted - please see http://www.eladian.com for further information.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-23 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1abe2159-2201-46c4-9c60-afc4f358ff6a@mail.eladian.com>
2012-07-19 20:53 ` [Bcache v14 PATCH] fix compiler error Daniel Wisehart
2012-07-23 21:12 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).