From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v6 03/13] block: Add bio_reset() Date: Wed, 22 Aug 2012 12:51:48 -0700 Message-ID: <20120822195148.GF19212@google.com> References: <1345655050-28199-1-git-send-email-koverstreet@google.com> <1345655050-28199-4-git-send-email-koverstreet@google.com> <20120822183426.GD19212@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120822183426.GD19212@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, vgoyal@redhat.com, mpatocka@redhat.com, bharrosh@panasas.com, Jens Axboe List-Id: dm-devel.ids On Wed, Aug 22, 2012 at 11:34:26AM -0700, Tejun Heo wrote: > On Wed, Aug 22, 2012 at 10:04:00AM -0700, Kent Overstreet wrote: > > Reusing bios is something that's been highly frowned upon in the past, > > but driver code keeps doing it anyways. If it's going to happen anyways, > > we should provide a generic method. > > > > This'll help with getting rid of bi_destructor - drivers/block/pktcdvd.c > > was open coding it, by doing a bio_init() and resetting bi_destructor. > > > > v5: Add a define BIO_RESET_BITS, to be very explicit about what parts of > > bio->bi_flags are saved. > > v6: Further commenting verbosity, per Tejun > > > > Signed-off-by: Kent Overstreet > > CC: Jens Axboe > > Given some users are converted later. > > Acked-by: Tejun Heo Noticed it was a bit fuzzy which fields get reset and which aren't and had a off-line discussion with Kent. The conclusion was that bi_end_io and bi_private should be reset and bi_integrity should be freed on bio_reset(). Thanks. -- tejun