From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md Date: Tue, 2 Oct 2012 16:16:30 -0400 Message-ID: <20121002201630.GI758@redhat.com> References: <1348526106-17074-1-git-send-email-koverstreet@google.com> <1348526106-17074-12-git-send-email-koverstreet@google.com> <20121002194132.GF3283@redhat.com> <20121002201105.GL26488@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20121002201105.GL26488-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org List-Id: dm-devel.ids On Tue, Oct 02, 2012 at 01:11:05PM -0700, Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote: > > On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: > > > Random cleanup - this code was duplicated and it's not really specific > > > to md. > > > > > > Also added the ability to return the actual error code. > > > > Who is going to make use of actual error code and why checking > > BIO_UPTODATE is not sufficient (as existing code is doing)? > > Some things do, though it's not common and I forget where I saw it - > checking for -ENOTSUPPORTED vs. other stuff May be we can introduce "submit_bio_ret" stuff when we find the actual user in the series. Justifying code change becomes easier. Thanks Vivek