From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: dm-crypt parallelization patches Date: Tue, 9 Apr 2013 11:10:31 -0700 Message-ID: <20130409181031.GC6186@mtj.dyndns.org> References: <5151FF82.6090405@gmail.com> <20130326202837.GA5599@redhat.com> <20130328185327.GF14088@htj.dyndns.org> <20130328193343.GA15969@redhat.com> <20130328194443.GG14088@htj.dyndns.org> <20130328203808.GC15969@redhat.com> <20130328204522.GA25501@mtj.dyndns.org> <20130409175753.GA6186@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mikulas Patocka Cc: Jens Axboe , Vivek Goyal , Mike Snitzer , Milan Broz , dm-devel@redhat.com, Andi Kleen , dm-crypt@saout.de, linux-kernel@vger.kernel.org, Christoph Hellwig , Christian Schmidt List-Id: dm-devel.ids Hey, On Tue, Apr 09, 2013 at 02:08:06PM -0400, Mikulas Patocka wrote: > > Hmmm? Why not just keep the issuing order along with plugging > > boundaries? > > What do you mean? > > I used to have a patch that keeps order of requests as they were > introduced, but sorting the requests according to sector number is a bit > simpler. You're still destroying the context information. Please just keep the issuing order along with plugging boundaries. > > As I wrote before, please use bio_associate_current(). Currently, > > dm-crypt is completely messing up all the context information that cfq > > depends on to schedule IOs. Of course, it doesn't perform well. > > bio_associate_current() is only valid on a system with cgroups and there > are no cgroups on the kernel where I tested it. It is an empty function: > > static inline int bio_associate_current(struct bio *bio) { return -ENOENT; } Yeah, because blkcg was the only user. Please feel free to drop the ifdefs. It covers both iocontext and cgroup association. Thanks. -- tejun