From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: [PATCH 1/2] Revert "Revert "math64: New div64_u64_rem helper"" Date: Tue, 20 Aug 2013 09:00:46 +0200 Message-ID: <20130820070045.GA1665@redhat.com> References: <1376078164-23147-1-git-send-email-snitzer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1376078164-23147-1-git-send-email-snitzer@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Mike Snitzer Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Mikulas Patocka , Frederic Weisbecker , Ingo Molnar List-Id: dm-devel.ids On Fri, Aug 09, 2013 at 03:56:03PM -0400, Mike Snitzer wrote: > This reverts commit f3002134158092178be81339ec5a22ff80e6c308. > > div64_u64_rem was removed because there were no other users. > > But Device Mapper's I/O statistics support has a need for > div64_u64_rem; reintroduce this helper. This slows down div64_u64 operation, especially on 32-bit systems. Since dm statistic code is possibly not performance critical perhaps you could use something like below instead to calculate remainder: res = div64_u64(a, b); rem = a - b*res; Stanislaw