dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 3/3] dm: allow error target to replace immutable target
Date: Thu, 29 Aug 2013 14:04:24 -0400	[thread overview]
Message-ID: <20130829180424.GB13786@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1308291306200.14270@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Aug 29 2013 at  1:07pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> 
> 
> On Thu, 29 Aug 2013, Mike Snitzer wrote:
> 
> > On Thu, Aug 29 2013 at 10:37am -0400,
> > Mikulas Patocka <mpatocka@redhat.com> wrote:
> > 
> > > As I said - I think it would be better to remove the immutable flag than 
> > > to create more flags to bypass it.
> > 
> > Immutable was introduced to prevent dangerous scenarios that weren't
> > accounted for in original design, etc.  It solved your crash when you
> > rep;aced a thin-pool with an empty table.
> > 
> > immutable is staying for now.  And as it turns out allowing error target
> > to override an immutable target was always held to be a logical/possible
> > future relaxation of the immutable constraint.
> > 
> > Mike
> 
> If you can replace a thin-pool target with an error target - so why can't 
> you replace a thin-pool target with linear (or any other) target?
> 
> I don't see why the error target should be special.

error target gives us the ability to disconnect the thin-pool from the
underlying devices.  It is practical for testing, etc.

What use-case are you saying will be valid to switch a thin-pool target
to linear?

  reply	other threads:[~2013-08-29 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29  3:21 [PATCH 1/3] dm ioctl: increase granularity of type_lock when loading table Mike Snitzer
2013-08-29  3:21 ` [PATCH 2/3] dm ioctl: cleanup error handling in table_load Mike Snitzer
2013-08-29  3:21 ` [PATCH 3/3] dm: allow error target to replace immutable target Mike Snitzer
2013-08-29 14:37   ` Mikulas Patocka
2013-08-29 14:44     ` Mike Snitzer
2013-08-29 17:07       ` Mikulas Patocka
2013-08-29 18:04         ` Mike Snitzer [this message]
2013-08-29 19:09           ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829180424.GB13786@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).