Linux Device Mapper development
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH maybe-for-3.13 01/20] dm thin: initialize dm_thin_new_mapping returned by get_next_mapping
Date: Mon, 6 Jan 2014 14:21:45 +0000	[thread overview]
Message-ID: <20140106142145.GC6766@debian> (raw)
In-Reply-To: <1387582653-13647-2-git-send-email-snitzer@redhat.com>

On Fri, Dec 20, 2013 at 06:37:14PM -0500, Mike Snitzer wrote:
> As additional members are added to the dm_thin_new_mapping structure
> care should be taken to make sure they get initialized before use.

ACK.

> +	memset(m, 0, sizeof(struct dm_thin_new_mapping));
> +	INIT_LIST_HEAD(&m->list);
> +	m->bio = NULL;

Remove redundant m->bio assignment?

  reply	other threads:[~2014-01-06 14:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 23:37 [PATCH for-next 00/20] dm: current patches queued in linux-dm.git for-next Mike Snitzer
2013-12-20 23:37 ` [PATCH maybe-for-3.13 01/20] dm thin: initialize dm_thin_new_mapping returned by get_next_mapping Mike Snitzer
2014-01-06 14:21   ` Joe Thornber [this message]
2013-12-20 23:37 ` [PATCH maybe-for-3.13 02/20] dm thin: fix discard support to a previously shared block Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 03/20] dm table: remove unused buggy code that extends the targets array Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 04/20] dm delay: use per-bio data instead of a mempool and slab cache Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 05/20] dm space map metadata: limit errors in sm_metadata_new_block Mike Snitzer
2014-01-06 14:25   ` Joe Thornber
2013-12-20 23:37 ` [PATCH for-3.14 06/20] dm persistent data: cleanup dm-thin specific references in text Mike Snitzer
2014-01-06 14:25   ` Joe Thornber
2013-12-20 23:37 ` [PATCH for-3.14 07/20] dm thin: use bool rather than unsigned for flags in structures Mike Snitzer
2014-01-06 14:27   ` Joe Thornber
2013-12-20 23:37 ` [PATCH for-3.14 08/20] dm thin: return error from alloc_data_block if pool is not in write mode Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 09/20] dm thin: add mappings to end of prepared_* lists Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 10/20] dm thin: factor out check_low_water_mark and use bools Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 11/20] dm thin: handle metadata failures more consistently Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 12/20] dm thin: log info when growing the data or metadata device Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 13/20] dm thin: cleanup and improve no space handling Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 14/20] dm thin: requeue bios to DM core if no_free_space and in read-only mode Mike Snitzer
2014-01-06 14:35   ` Joe Thornber
2014-01-06 14:38     ` Joe Thornber
2013-12-20 23:37 ` [PATCH for-3.14 15/20] dm thin: add error_if_no_space feature Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 16/20] dm thin: eliminate the no_free_space flag Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 17/20] dm thin: fix set_pool_mode exposed pool operation races Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 18/20] dm thin: fix pool_preresume resize with heavy IO races Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 19/20] dm cache policy mq: use list_del_init instead of list_del + INIT_LIST_HEAD Mike Snitzer
2013-12-20 23:37 ` [PATCH for-3.14 20/20] dm cache policy mq: introduce three promotion threshold tunables Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106142145.GC6766@debian \
    --to=thornber@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox