From: Mike Snitzer <snitzer@redhat.com>
To: Brassow Jonathan <jbrassow@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>, ejt@redhat.com
Subject: Re: [PATCH v2 for-3.14] dm cache: add block sizes and total cache blocks to status output
Date: Thu, 16 Jan 2014 14:35:33 -0500 [thread overview]
Message-ID: <20140116193533.GA30851@redhat.com> (raw)
In-Reply-To: <FDEC03AD-6294-403B-8AC9-0A1DF4230E9D@redhat.com>
On Thu, Jan 16 2014 at 12:18pm -0500,
Brassow Jonathan <jbrassow@redhat.com> wrote:
>
> On Jan 15, 2014, at 10:34 PM, Mike Snitzer wrote:
>
> > On Wed, Jan 15 2014 at 8:16pm -0500,
> > Brassow Jonathan <jbrassow@redhat.com> wrote:
> >
> >> I know I'm pushing my luck...
> >>
> >> Is it too late to ask for just one more thing? Would you also consider printing the policy name in the status (INFO)?
> >> <policy_name> <#policy args> <policy args>
> >>
> >> This is especially useful when you pass in "default" in the CTR, because you cannot get this value from anywhere... right?
> >
> > For the benefit of others, I pushed the change here:
> > http://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=2f20afc4c3f69030204ce55f24bc68971b500b8a
>
> This doesn't quite produce the info we want. If I specify "default"
> in the CTR table, I want the status to show me what the result was
> (i.e. "mq"). It currently seems to be printing "default" back at
> me... which isn't helpful. :)
I updated the commit, see:
http://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=2e68c4e6caad9fdadc1cef8b6cb9569192e8a42b
I've also verified it works (by updating my local
device-mapper-test-suite code, will get these changes to joe soon)
next prev parent reply other threads:[~2014-01-16 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:04 [PATCH for-3.14] dm cache: add total cache blocks to status output Mike Snitzer
2014-01-09 21:28 ` Brassow Jonathan
2014-01-09 22:13 ` Mike Snitzer
2014-01-09 23:55 ` [PATCH v2 for-3.14] dm cache: add block sizes and " Mike Snitzer
2014-01-10 0:09 ` [PATCH] dmts: update CacheStatus to parse new " Mike Snitzer
2014-01-16 1:16 ` [PATCH v2 for-3.14] dm cache: add block sizes and total cache blocks to " Brassow Jonathan
2014-01-16 4:34 ` Mike Snitzer
2014-01-16 17:18 ` Brassow Jonathan
2014-01-16 19:35 ` Mike Snitzer [this message]
2014-01-10 1:16 ` [PATCH for-3.14] dm cache: add " Brassow Jonathan
2014-01-10 10:32 ` Joe Thornber
2014-01-10 10:42 ` Joe Thornber
2014-01-10 14:17 ` Mike Snitzer
2014-01-10 10:11 ` Joe Thornber
2014-01-10 14:10 ` [PATCH v3 for-3.14] dm cache: add block sizes and " Mike Snitzer
2014-01-10 15:13 ` Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116193533.GA30851@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=jbrassow@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox