Linux Device Mapper development
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ondrej Kozina <okozina@redhat.com>,
	Mike Snitzer <msnitzer@redhat.com>,
	dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: A patchset to limit the number of outstanding bios
Date: Mon, 13 Oct 2014 17:03:18 +0100	[thread overview]
Message-ID: <20141013160317.GD27596@debian> (raw)
In-Reply-To: <alpine.LRH.2.02.1410131113450.3569@file01.intranet.prod.int.rdu2.redhat.com>

On Mon, Oct 13, 2014 at 11:27:20AM -0400, Mikulas Patocka wrote:
> Hi
> 
> I'm announcing the release of a patchset that limits the number of 
> outstanding bios in the device mapper.

Interesting; Mike and I were considering this for throttling io to
thinp a couple of weeks ago.  The reason we didn't go with this was,
for thinp, there are cheap bios (eg, a quick remap) and expensive bios
(eg, one that triggers a copy on write exception).  This means it's
very hard to come up with a single number that represents too many
bios.  Instead I throttle by looking at how long it's taking the
worker thread to get through it's work queue.

Could you make this limit optional please?  eg, setting the limit to 0
turns it off, and I'd prefer a default of 0/off.

- Joe

  reply	other threads:[~2014-10-13 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 15:27 A patchset to limit the number of outstanding bios Mikulas Patocka
2014-10-13 16:03 ` Joe Thornber [this message]
2014-10-13 16:20 ` Mike Snitzer
2014-10-13 20:52   ` Mikulas Patocka
2014-10-15 12:12   ` device-mapper lilofile
2014-10-21  1:36   ` dm-thin lilofile
2014-10-21  9:32     ` dm-thin Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013160317.GD27596@debian \
    --to=thornber@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=msnitzer@redhat.com \
    --cc=okozina@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox