Linux Device Mapper development
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: dm: do not call dm_sync_table() when creating new devices
Date: Wed, 5 Nov 2014 09:15:43 -0500	[thread overview]
Message-ID: <20141105141542.GB14285@redhat.com> (raw)
In-Reply-To: <1415194550-121498-1-git-send-email-hare@suse.de>

On Wed, Nov 05 2014 at  8:35am -0500,
Hannes Reinecke <hare@suse.de> wrote:

> When creating new devices dm_sync_table() calls
> synchronize_rcu_expedited(), causing _all_ pending
> RCU pointers to be flushed. This causes a latency
> overhead especially noticeable when creating lots
> of devices.
> And all of this is pointless as there are no old
> maps to be disconnected, and hence no stale pointers
> which would need to be cleared up.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Looks good, I'll get it staged for 3.19 (will need to be rebased on the
linux-dm.git 'dm-for-3.19' branch given the suspend related refactoring
there, but I'll take care of it as needed).

  reply	other threads:[~2014-11-05 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 13:35 [PATCH] dm: do not call dm_sync_table() when creating new devices Hannes Reinecke
2014-11-05 14:15 ` Mike Snitzer [this message]
2014-11-05 22:16 ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105141542.GB14285@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox