Linux Device Mapper development
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Vasily Tarasov <tarasov@vasily.name>
Cc: Joe Thornber <thornber@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	dm-devel@redhat.com, Philip Shilane <philip.shilane@emc.com>,
	Sonam Mandal <sonam.dp42@gmail.com>,
	Erez Zadok <ezk@fsl.cs.sunysb.edu>
Subject: Re: [PATCH RFCv2 10/10] dm-dedup: documentation
Date: Fri, 30 Jan 2015 13:55:00 -0500	[thread overview]
Message-ID: <20150130185500.GB8364@redhat.com> (raw)
In-Reply-To: <53ffb65d.144d320a.0fce.12eb@mx.google.com>

On Thu, Aug 28, 2014 at 06:16:50PM -0400, Vasily Tarasov wrote:

[..]
> +Example
> +=======
> +
> +Decide on metadata and data devices:
> +   # META_DEV=/dev/sdX
> +   # DATA_DEV=/dev/sdY
> +
> +Compute target size assuming 1.5 dedup ratio:
> +   # DATA_DEV_SIZE=`blockdev --getsz $DATA_DEV`
> +   # TARGET_SIZE=`expr $DATA_DEV_SIZE \* 10 / 15`

Is above correct? With dm dedupe ratio of 1.5, target size
should be (15/10) * DATA_DEV_SIZE and not vice-a-versa?

> +
> +Reset metadata device:
> +   # dd if=/dev/zero of=$META_DEV bs=4096 count=1
> +
> +Setup a target:
> +	echo "0 $TARGET_SIZE dedup $META_DEV $DATA_DEV 4096 md5 cowbtree 100" |\
> +				dmsetup create mydedup
> +

I setup a target and did "dmsetup table" and "dmsetup status" and they
both seem to be outputting same thing. I think output of "dmsetup table"
is wrong. As per the man page of dmsetup, you are supposed to output
the table in a format which can be directly feedback into tagrget for
loading.

#dmsetup table
testdedup: 0 2930287752 dedup 244190646 244190646 0 0 4096 8:32 8:48 0 0
0 0 0 0

#dmsetup status
testdedup: 0 2930287752 dedup 244190646 244190646 0 0 4096 8:32 8:48 0 0
0 0 0 0

Thanks
Vivek

  reply	other threads:[~2015-01-30 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 22:16 [PATCH RFCv2 10/10] dm-dedup: documentation Vasily Tarasov
2015-01-30 18:55 ` Vivek Goyal [this message]
2015-02-03 16:20   ` Vasily Tarasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130185500.GB8364@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=ezk@fsl.cs.sunysb.edu \
    --cc=hch@infradead.org \
    --cc=philip.shilane@emc.com \
    --cc=snitzer@redhat.com \
    --cc=sonam.dp42@gmail.com \
    --cc=tarasov@vasily.name \
    --cc=thornber@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox