Linux Device Mapper development
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH for v4.3-rc] dm: fix request-based dm error reporting
Date: Tue, 6 Oct 2015 10:13:47 -0400	[thread overview]
Message-ID: <20151006141346.GA30705@redhat.com> (raw)
In-Reply-To: <20151006041953.GA7948@xzibit.linux.bs1.fc.nec.co.jp>

On Tue, Oct 06 2015 at 12:19am -0400,
Junichi Nomura <j-nomura@ce.jp.nec.com> wrote:

> end_clone_bio() is a endio callback for clone bio and should check
> and save the clone's bi_error for error reporting.  However,
> 4246a0b63bd8 ("block: add a bi_error field to struct bio") changed
> the function to check the original bio's bi_error, which is 0.
> 
> Without this fix, clone's error is ignored and reported to the
> original request as success.  Thus data corruption will be observed.
> 
> Fixes: 4246a0b63bd8 ("block: add a bi_error field to struct bio")
> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
> Cc: Christoph Hellwig <hch@lst.de>

Thanks, I've applied it here:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=50887bd139b83ce4489ed865a04bf1be5559c4ad

I'll send it to Linus by the end of the week for 4.3-rc5 inclusion.

      reply	other threads:[~2015-10-06 14:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06  4:19 [PATCH for v4.3-rc] dm: fix request-based dm error reporting Junichi Nomura
2015-10-06 14:13 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006141346.GA30705@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=j-nomura@ce.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox