From: Mike Snitzer <snitzer@redhat.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: linux-kernel@vger.kernel.org, mpatocka@redhat.com, axboe@fb.com,
j-nomura@ce.jp.nec.com, neilb@suse.com, dm-devel@redhat.com
Subject: Re: dm: drop unnecessary assignment of md->queue
Date: Wed, 24 Feb 2016 11:58:23 -0500 [thread overview]
Message-ID: <20160224165823.GA15480@redhat.com> (raw)
In-Reply-To: <1456301738-16076-1-git-send-email-bob.liu@oracle.com>
On Wed, Feb 24 2016 at 3:15am -0500,
Bob Liu <bob.liu@oracle.com> wrote:
> md->queue and q are the same thing in dm_init_request_based_queue() and
> dm_init_request_based_blk_mq_queue().
>
> Also drop the temporary struct request_queue *q.
Yeah, I carried the extra assignment just as a form of documentation but
your patch is correct (they aren't needed). I've rebased your patch
ontop of linux-dm.git's 'dm-4.6' and have staged it in linux-next.
parent reply other threads:[~2016-02-24 16:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1456301738-16076-1-git-send-email-bob.liu@oracle.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224165823.GA15480@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@fb.com \
--cc=bob.liu@oracle.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).