From: Mike Snitzer <snitzer@redhat.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: dm-devel@redhat.com, linux-scsi@vger.kernel.org,
sagig@dev.mellanox.co.il, linux-block@vger.kernel.org,
jmoyer@redhat.com, j-nomura@ce.jp.nec.com
Subject: Re: [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance
Date: Fri, 1 Apr 2016 09:22:19 -0400 [thread overview]
Message-ID: <20160401132219.GA24355@redhat.com> (raw)
In-Reply-To: <6c6623e7f92e31daf1586d266fa03e1d@suse.de>
On Fri, Apr 01 2016 at 4:12am -0400,
Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On 2016-03-31 22:04, Mike Snitzer wrote:
> >I developed these changes some weeks ago but have since focused on
> >regression and performance testing on larger NUMA systems.
> >
> >For regression testing I've been using mptest:
> >https://github.com/snitm/mptest
> >
> >For performance testing I've been using a null_blk device (with
> >various configuration permutations, e.g. pinning memory to a
> >particular NUMA node, and varied number of submit_queues).
> >
> >By eliminating multipath's heavy use of the m->lock spinlock in the
> >fast IO paths serious performance improvements are realized.
>
> Hi Mike,
>
> Are this the patches you pointed Hannes to?
>
> If yes, please add my Tested-by: Johannes Thumshirn <jthumshirn@suse.de>
No they are not.
Hannes seems to have last pulled in my DM mpath changes that (ab)used RCU.
I ended up dropping those changes and this patchset is the replacement.
So please retest with this patchset (I know you guys have a large setup
that these changes are very relevant for). If you could actually share
_how_ yo've tested that'd help me understand how these changes are
holding up. So far all looks good for me...
Mike
next prev parent reply other threads:[~2016-04-01 13:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 20:04 [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance Mike Snitzer
2016-03-31 20:04 ` [RFC PATCH 1/4] dm mpath: switch to using bitops for state flags Mike Snitzer
2016-04-01 8:46 ` [dm-devel] " Johannes Thumshirn
2016-04-07 14:59 ` Hannes Reinecke
2016-03-31 20:04 ` [RFC PATCH 2/4] dm mpath: use atomic_t for counting members of 'struct multipath' Mike Snitzer
2016-04-01 8:48 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:02 ` Hannes Reinecke
2016-03-31 20:04 ` [RFC PATCH 3/4] dm mpath: move trigger_event member to the end " Mike Snitzer
2016-04-01 8:50 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:03 ` Hannes Reinecke
2016-03-31 20:04 ` [RFC PATCH 4/4] dm mpath: eliminate use of spinlock in IO fast-paths Mike Snitzer
2016-04-01 9:02 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:03 ` Hannes Reinecke
2016-04-01 8:12 ` [dm-devel] [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance Johannes Thumshirn
2016-04-01 13:22 ` Mike Snitzer [this message]
2016-04-01 13:37 ` Johannes Thumshirn
2016-04-01 14:14 ` Mike Snitzer
2016-04-07 14:58 ` Hannes Reinecke
2016-04-07 15:34 ` Mike Snitzer
2016-04-08 11:42 ` [dm-devel] " Johannes Thumshirn
2016-04-08 19:29 ` Mike Snitzer
2016-04-13 7:03 ` [dm-devel] " Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401132219.GA24355@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jmoyer@redhat.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).