From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm: ioctl: use kvfree Date: Mon, 11 Apr 2016 11:17:15 -0400 Message-ID: <20160411151714.GB25938@redhat.com> References: <1460387677-19948-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460387677-19948-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-raid-owner@vger.kernel.org To: Sudip Mukherjee Cc: Alasdair Kergon , Shaohua Li , linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org List-Id: dm-devel.ids On Mon, Apr 11 2016 at 11:14am -0400, Sudip Mukherjee wrote: > We can use kvfree() instead of calling kfree() and vfree() based on > if-else and param_flags. kvfree() will check the type of address and > will call the respective function to free it. > Additionally we can also remove the use of DM_PARAMS_KMALLOC and > DM_PARAMS_VMALLOC. > > Signed-off-by: Sudip Mukherjee Have you actually tested htis? Last time I looked to do this it exposed crashes. I don't have time to dig into this again right now but this is _not_ as simple as this patch implies.