dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Gris Ge <fge@redhat.com>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH V5 3/3] Introducing multipath C API
Date: Tue, 5 Jul 2016 11:17:19 +0800	[thread overview]
Message-ID: <20160705031719.GA4128@redhat.com> (raw)
In-Reply-To: <90c5e679-2942-12ce-4e77-9cc1f475ee45@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 678 bytes --]

On Mon, Jul 04, 2016 at 06:32:56PM +0200, Xose Vazquez Perez wrote:
> Gris Ge wrote:
> 
> > +	perl -i -pe 's|__INCLUDEDIR__|$(includedir)|g' \
> > +		$(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
> 
> Please, replace perl with sed, awk or any other basic tool.
> 
Hi Xose Vazquez Perez,

it's quit complex to handle folder path with '/' in sed or
awk unless I missed anything.

As we need perl in 'kernel-doc' tool blow to generate manpage,
can I keep it?
> > +	perl docs/kernel-doc -man $(HEADERS) | perl docs/split-man.pl docs/man
> > +	@for file in docs/man/*.3; do \
> > +		gzip -f $$file; \
> > +	done
> > +	find docs/man -type f -name \*[0-9].gz

-- 
Gris Ge

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2016-07-05  3:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 16:32 [PATCH V5 3/3] Introducing multipath C API Xose Vazquez Perez
2016-07-05  3:17 ` Gris Ge [this message]
2016-07-10 16:26   ` Xose Vazquez Perez
  -- strict thread matches above, loose matches on Subject: below --
2016-07-10 16:23 Xose Vazquez Perez
2016-07-12  5:29 ` Gris Ge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705031719.GA4128@redhat.com \
    --to=fge@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).