* Re: [PATCH V5 3/3] Introducing multipath C API
@ 2016-07-10 16:23 Xose Vazquez Perez
2016-07-12 5:29 ` Gris Ge
0 siblings, 1 reply; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-07-10 16:23 UTC (permalink / raw)
To: Gris Ge, device-mapper development
Gris Ge wrote:
> diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> new file mode 100644
> index 0000000..ce7ca3f
> --- /dev/null
> +++ b/libdmmp/Makefile
> @@ -0,0 +1,78 @@
> +# Makefile
> +#
> +# Copyright (C) 2015 - 2016 Red Hat, Inc.
> +# Gris Ge <fge@redhat.com>
> +#
> +include ../Makefile.inc
> +
> +LIBDMMP_VERSION=0.1.0
> +SONAME=$(LIBDMMP_VERSION)
> +DEVLIB = libdmmp.so
> +LIBS = $(DEVLIB).$(SONAME)
> +LIBDEPS = -pthread
> +PKGFILE = libdmmp.pc
> +EXTRA_MAN_FILES = libdmmp.h.3
> +HEADERS = libdmmp/libdmmp.h
> +OBJS = libdmmp.o libdmmp_mp.o libdmmp_pg.o libdmmp_path.o libdmmp_misc.o
> +
> +CFLAGS += -fvisibility=hidden -I$(libdmmpdir) -I$(mpathcmddir) \
> + $(shell pkg-config --cflags json-c)
> +LDFLAGS += $(shell pkg-config --libs json-c) -L$(mpathcmddir) -lmpathcmd
> +
> +all: $(LIBS) doc
> +
> +$(LIBS): $(OBJS)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) \
> + -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)
> + ln -sf $@ $(DEVLIB)
In Makefile(s), replace "ln -arguments" and "rm -arguments" with $(LN) $(RM).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V5 3/3] Introducing multipath C API
2016-07-10 16:23 [PATCH V5 3/3] Introducing multipath C API Xose Vazquez Perez
@ 2016-07-12 5:29 ` Gris Ge
0 siblings, 0 replies; 5+ messages in thread
From: Gris Ge @ 2016-07-12 5:29 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]
On Sun, Jul 10, 2016 at 06:23:39PM +0200, Xose Vazquez Perez wrote:
> Gris Ge wrote:
>
> > diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> > new file mode 100644
> > index 0000000..ce7ca3f
> > --- /dev/null
> > +++ b/libdmmp/Makefile
> > @@ -0,0 +1,78 @@
> > + ln -sf $@ $(DEVLIB)
>
> In Makefile(s), replace "ln -arguments" and "rm -arguments" with
> $(LN) $(RM).
Thanks. Will fix them in V6 patch set.
--
Gris Ge
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V5 3/3] Introducing multipath C API
@ 2016-07-04 16:32 Xose Vazquez Perez
2016-07-05 3:17 ` Gris Ge
0 siblings, 1 reply; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-07-04 16:32 UTC (permalink / raw)
To: Gris Ge, Christophe Varoqui, device-mapper development
Gris Ge wrote:
> diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> new file mode 100644
> index 0000000..ce7ca3f
> --- /dev/null
> +++ b/libdmmp/Makefile
> @@ -0,0 +1,78 @@
> +# Makefile
> +#
> +# Copyright (C) 2015 - 2016 Red Hat, Inc.
> +# Gris Ge <fge@redhat.com>
> +#
> +include ../Makefile.inc
> +
> +LIBDMMP_VERSION=0.1.0
> +SONAME=$(LIBDMMP_VERSION)
> +DEVLIB = libdmmp.so
> +LIBS = $(DEVLIB).$(SONAME)
> +LIBDEPS = -pthread
> +PKGFILE = libdmmp.pc
> +EXTRA_MAN_FILES = libdmmp.h.3
> +HEADERS = libdmmp/libdmmp.h
> +OBJS = libdmmp.o libdmmp_mp.o libdmmp_pg.o libdmmp_path.o libdmmp_misc.o
> +
> +CFLAGS += -fvisibility=hidden -I$(libdmmpdir) -I$(mpathcmddir) \
> + $(shell pkg-config --cflags json-c)
> +LDFLAGS += $(shell pkg-config --libs json-c) -L$(mpathcmddir) -lmpathcmd
> +
> +all: $(LIBS) doc
> +
> +$(LIBS): $(OBJS)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) \
> + -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)
> + ln -sf $@ $(DEVLIB)
> +
> +install:
> + $(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(syslibdir)/$(LIBS)
> + $(INSTALL_PROGRAM) -m 644 -D \
> + $(HEADERS) $(DESTDIR)/$(includedir)/$(HEADERS)
> + ln -sf $(LIBS) $(DESTDIR)/$(syslibdir)/$(DEVLIB)
> + $(INSTALL_PROGRAM) -m 644 -D \
> + $(PKGFILE).in $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
> + perl -i -pe 's|__VERSION__|$(LIBDMMP_VERSION)|g' \
> + $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
> + perl -i -pe 's|__LIBDIR__|$(syslibdir)|g' \
> + $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
> + perl -i -pe 's|__INCLUDEDIR__|$(includedir)|g' \
> + $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
Please, replace perl with sed, awk or any other basic tool.
> + @for file in docs/man/*.3.gz; do \
> + $(INSTALL_PROGRAM) -m 644 -D \
> + $$file \
> + $(DESTDIR)/$(man3dir)/ || exit $?; \
> + done
> +
> +uninstall:
> + rm -f $(DESTDIR)$(syslibdir)/$(LIBS)
> + rm -f $(DESTDIR)$(includedir)/$(HEADERS)
> + rm -f $(DESTDIR)/$(syslibdir)/$(DEVLIB)
> + @for file in $(DESTDIR)/$(man3dir)/dmmp_*; do \
> + rm $$file; \
> + done
> + rm -f $(DESTDIR)$(man3dir)/libdmmp.h*
> +
> +clean:
> + rm -f core *.a *.o *.gz *.so *.so.*
> + rm -f docs/man/*.3.gz
> + $(MAKE) -C test clean
> +
> +check: all
> + $(MAKE) -C test check
> +
> +speed_test: all
> + $(MAKE) -C test speed_test
> +
> +doc: docs/man/$(EXTRA_MAN_FILES).gz
> +
> +docs/man/$(EXTRA_MAN_FILES).gz: $(HEADERS)
> + @for file in $(EXTRA_MAN_FILES); do \
> + $(INSTALL_PROGRAM) -v -m 644 -D docs/$$file docs/man/$$file; \
> + done
> + perl docs/kernel-doc -man $(HEADERS) | perl docs/split-man.pl docs/man
> + @for file in docs/man/*.3; do \
> + gzip -f $$file; \
> + done
> + find docs/man -type f -name \*[0-9].gz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V5 3/3] Introducing multipath C API
2016-07-04 16:32 Xose Vazquez Perez
@ 2016-07-05 3:17 ` Gris Ge
2016-07-10 16:26 ` Xose Vazquez Perez
0 siblings, 1 reply; 5+ messages in thread
From: Gris Ge @ 2016-07-05 3:17 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 678 bytes --]
On Mon, Jul 04, 2016 at 06:32:56PM +0200, Xose Vazquez Perez wrote:
> Gris Ge wrote:
>
> > + perl -i -pe 's|__INCLUDEDIR__|$(includedir)|g' \
> > + $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
>
> Please, replace perl with sed, awk or any other basic tool.
>
Hi Xose Vazquez Perez,
it's quit complex to handle folder path with '/' in sed or
awk unless I missed anything.
As we need perl in 'kernel-doc' tool blow to generate manpage,
can I keep it?
> > + perl docs/kernel-doc -man $(HEADERS) | perl docs/split-man.pl docs/man
> > + @for file in docs/man/*.3; do \
> > + gzip -f $$file; \
> > + done
> > + find docs/man -type f -name \*[0-9].gz
--
Gris Ge
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V5 3/3] Introducing multipath C API
2016-07-05 3:17 ` Gris Ge
@ 2016-07-10 16:26 ` Xose Vazquez Perez
0 siblings, 0 replies; 5+ messages in thread
From: Xose Vazquez Perez @ 2016-07-10 16:26 UTC (permalink / raw)
To: Gris Ge, Christophe Varoqui; +Cc: device-mapper development
On 07/05/2016 05:17 AM, Gris Ge wrote:
> On Mon, Jul 04, 2016 at 06:32:56PM +0200, Xose Vazquez Perez wrote:
>> Gris Ge wrote:
>>
>>> + perl -i -pe 's|__INCLUDEDIR__|$(includedir)|g' \
>>> + $(DESTDIR)/$(pkgconfdir)/$(PKGFILE)
>>
>> Please, replace perl with sed, awk or any other basic tool.
>
> it's quit complex to handle folder path with '/' in sed or
> awk unless I missed anything.
>
> As we need perl in 'kernel-doc' tool blow to generate manpage,
> can I keep it?
>
>>> + perl docs/kernel-doc -man $(HEADERS) | perl docs/split-man.pl docs/man
>>> + @for file in docs/man/*.3; do \
>>> + gzip -f $$file; \
>>> + done
>>> + find docs/man -type f -name \*[0-9].gz
>
This is up to Christophe's taste.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-12 5:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-10 16:23 [PATCH V5 3/3] Introducing multipath C API Xose Vazquez Perez
2016-07-12 5:29 ` Gris Ge
-- strict thread matches above, loose matches on Subject: below --
2016-07-04 16:32 Xose Vazquez Perez
2016-07-05 3:17 ` Gris Ge
2016-07-10 16:26 ` Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).