From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minfei Huang <mnghuan@gmail.com>
Subject: Re: [PATCH] dm: Return correct value in retry loop
Date: Mon, 12 Sep 2016 09:39:06 +0800
Message-ID: <20160912013906.GA24268@MinfeideMacBook-Pro.local>
References: <1473148829-3317-1-git-send-email-mnghuan@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1473148829-3317-1-git-send-email-mnghuan@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: agk@redhat.com, snitzer@redhat.com, shli@kernel.org
Cc: dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: dm-devel.ids

Ping.

Any comment is appreciate.

Thanks
Minfei

On 09/06/16 at 04:00P, Minfei Huang wrote:
> dm_resume will return sliently in retry loop's failure. Assign a correct
> return value in the failed loop.
> 
> Remove a useless assignment as well.
> 
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
>  drivers/md/dm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index fa9b1cb..c935cc8 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -2249,10 +2249,11 @@ static int __dm_resume(struct mapped_device *md, struct dm_table *map)
>  
>  int dm_resume(struct mapped_device *md)
>  {
> -	int r = -EINVAL;
> +	int r;
>  	struct dm_table *map = NULL;
>  
>  retry:
> +	r = -EINVAL;
>  	mutex_lock_nested(&md->suspend_lock, SINGLE_DEPTH_NESTING);
>  
>  	if (!dm_suspended_md(md))
> @@ -2277,10 +2278,8 @@ retry:
>  
>  	clear_bit(DMF_SUSPENDED, &md->flags);
>  
> -	r = 0;
>  out:
>  	mutex_unlock(&md->suspend_lock);
> -
>  	return r;
>  }
>  
> -- 
> 2.7.4 (Apple Git-66)
>