From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@fb.com>, Mike Christie <mchristi@redhat.com>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
Damien Le Moal <Damien.LeMoal@hgst.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 3/3] block: Improve bio_set_op_attrs() robustness
Date: Wed, 14 Sep 2016 11:59:26 +0200 [thread overview]
Message-ID: <20160914095926.GC21938@lst.de> (raw)
In-Reply-To: <2a6c6cbd-ccc6-ee89-99ca-c0267cf17ec0@sandisk.com>
On Wed, Sep 14, 2016 at 10:46:22AM +0200, Bart Van Assche wrote:
> Since REQ_OP_BITS == 3 and __REQ_NR_BITS == 30 it is not that hard
> to pass an op_flags argument to bio_set_op_attrs() that is larger
> than the number of bits reserved for the op_flags argument. Complain
> if this happens. Additionally, ensure that negative arguments trigger
> a complaint (1 << ... is signed while 1U << ... is unsigned; adding
> 0U to an integer expression causes it to be promoted to an unsigned
> type).
And this does the proper check.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-09-14 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:42 [PATCH 0/3] block: Improve bio_set_op_attrs() robustness Bart Van Assche
2016-09-14 8:44 ` [PATCH 1/3] block: Document that bio_op() uses the data type of bio.bi_opf Bart Van Assche
2016-09-14 8:52 ` Johannes Thumshirn
2016-09-14 9:56 ` Christoph Hellwig
2016-09-14 8:45 ` [PATCH 2/3] block, dm-crypt, btrfs: Introduce bio_flags() Bart Van Assche
2016-09-14 8:53 ` Johannes Thumshirn
2016-09-14 9:58 ` Christoph Hellwig
2016-09-14 9:59 ` Christoph Hellwig
2016-09-14 8:46 ` [PATCH 3/3] block: Improve bio_set_op_attrs() robustness Bart Van Assche
2016-09-14 8:55 ` Johannes Thumshirn
2016-09-14 9:59 ` Christoph Hellwig [this message]
2016-09-14 14:48 ` [PATCH 0/3] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914095926.GC21938@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@hgst.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=clm@fb.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).