From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <bart.vanassche@gmail.com>
Cc: axboe@kernel.dk, dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] blk-mq: introduce blk_mq_delay_kick_requeue_list()
Date: Wed, 14 Sep 2016 09:45:46 -0400 [thread overview]
Message-ID: <20160914134545.GA29338@redhat.com> (raw)
In-Reply-To: <7745fd2a-b8e3-f2c8-5154-4f0bcd263338@acm.org>
On Wed, Sep 14 2016 at 7:28am -0400,
Bart Van Assche <bart.vanassche@gmail.com> wrote:
> On 09/13/2016 06:01 PM, Mike Snitzer wrote:
> >+void blk_mq_delay_kick_requeue_list(struct request_queue *q,
> >+ unsigned long msecs)
> >+{
> >+ kblockd_schedule_delayed_work(&q->requeue_work, msecs);
> >+}
> >+EXPORT_SYMBOL(blk_mq_delay_kick_requeue_list);
>
> Hello Mike,
>
> I think kblockd_schedule_delayed_work() expects that the second
> argument is a number of jiffies instead of a number of milliseconds.
Yeap, you're right. An earlier version was using msecs_to_jiffies() in
the DM caller. I'll submit v2.
next prev parent reply other threads:[~2016-09-14 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 16:01 [PATCH for-4.9 0/3] allow delayed requeue of blk-mq requests Mike Snitzer
2016-09-13 16:01 ` [PATCH 1/3] blk-mq: introduce blk_mq_delay_kick_requeue_list() Mike Snitzer
2016-09-14 6:22 ` Hannes Reinecke
2016-09-14 11:28 ` Bart Van Assche
2016-09-14 13:45 ` Mike Snitzer [this message]
2016-09-14 15:04 ` Jens Axboe
2016-09-14 15:13 ` Mike Snitzer
2016-09-13 16:01 ` [PATCH 2/3] dm rq: add DM_MAPIO_DELAY_REQUEUE to delay requeue of blk-mq requests Mike Snitzer
2016-09-14 6:24 ` Hannes Reinecke
2016-09-14 13:51 ` Mike Snitzer
2016-09-13 16:01 ` [PATCH 3/3] dm mpath: delay the requeue of blk-mq requests while all paths down Mike Snitzer
2016-09-14 6:25 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914134545.GA29338@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@gmail.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).