From: Christoph Hellwig <hch@lst.de>
To: Yibin Wang <wangyibin@huawei.com>
Cc: Jiangyiwen <jiangyiwen@huawei.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: dm-mpath: Handling SCSI-3 PR RELEASE in multi-controller environment
Date: Fri, 14 Oct 2016 15:48:25 +0200 [thread overview]
Message-ID: <20161014134825.GA21707@lst.de> (raw)
In-Reply-To: <57FF6CFD.3060708@huawei.com>
Hi Yibin,
On Thu, Oct 13, 2016 at 07:16:13PM +0800, Yibin Wang wrote:
> BTW, did you mean using dm_pr::fail_early as the indication whether
> multipath_iterate_devices() should fail early upon failure? If that's the
> case,
> I can't see it is used anywhere except in dm_pr_register().
>
> Please correct me if I am wrong. Thanks!
Yes, fail_early was intended to ensure we don't break out of the
loop. But it's obviously not checked in the current code, so we'll need
to fix it indeed. If you have existing patches for that please send
them out, else I'm going to look into it.
next prev parent reply other threads:[~2016-10-14 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 13:12 dm-mpath: Handling SCSI-3 PR RELEASE in multi-controller environment wangyibin
2016-10-09 15:16 ` Christoph Hellwig
2016-10-13 9:19 ` Yibin Wang
2016-10-13 11:16 ` Yibin Wang
2016-10-14 13:48 ` Christoph Hellwig [this message]
2016-10-14 14:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-09-21 9:14 jiangyiwen
2016-09-21 15:04 ` Mike Snitzer
2016-09-21 17:14 ` Christoph Hellwig
2016-09-22 8:14 ` jiangyiwen
2016-09-26 16:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014134825.GA21707@lst.de \
--to=hch@lst.de \
--cc=dm-devel@redhat.com \
--cc=jiangyiwen@huawei.com \
--cc=snitzer@redhat.com \
--cc=wangyibin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).