From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: peng.liang5@zte.com.cn
Cc: dm-devel@redhat.com, zhang.kai16@zte.com.cn
Subject: Re: [PATCH] libmultipath/checkers/rbd: fix free in libcheck_init
Date: Fri, 4 Nov 2016 12:50:21 -0500 [thread overview]
Message-ID: <20161104175021.GJ1972@octiron.msp.redhat.com> (raw)
In-Reply-To: <1478246069-3448-1-git-send-email-peng.liang5@zte.com.cn>
On Fri, Nov 04, 2016 at 03:54:29PM +0800, peng.liang5@zte.com.cn wrote:
> From: PengLiang <peng.liang5@zte.com.cn>
ACK
-Ben
>
> There is an incorrect free maybe causing memory leak.
>
> Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
> ---
> libmultipath/checkers/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/checkers/rbd.c b/libmultipath/checkers/rbd.c
> index 481d860..9ea0572 100644
> --- a/libmultipath/checkers/rbd.c
> +++ b/libmultipath/checkers/rbd.c
> @@ -174,7 +174,7 @@ int libcheck_init(struct checker * c)
>
> ct->image = strdup(image);
> if (!ct->image)
> - goto free_info;
> + goto free_username;
>
> pool = udev_device_get_sysattr_value(bus_dev, "pool");
> if (!pool)
> --
> 2.8.1.windows.1
prev parent reply other threads:[~2016-11-04 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 7:54 [PATCH] libmultipath/checkers/rbd: fix free in libcheck_init peng.liang5
2016-11-04 17:50 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104175021.GJ1972@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=peng.liang5@zte.com.cn \
--cc=zhang.kai16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).