From: Keith Busch <keith.busch@intel.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 2/2] Fill NVMe specific path info
Date: Tue, 21 Feb 2017 16:06:57 -0500 [thread overview]
Message-ID: <20170221210657.GA2453@localhost.localdomain> (raw)
In-Reply-To: <20170220175759.GA22981@octiron.msp.redhat.com>
On Mon, Feb 20, 2017 at 11:57:59AM -0600, Benjamin Marzinski wrote:
> > +
> > + snprintf(pp->vendor_id, SCSI_VENDOR_SIZE, "NVME");
> > + snprintf(pp->product_id, SCSI_PRODUCT_SIZE, "%s", udev_device_get_sysattr_value(nvme, "model"));
> > + snprintf(pp->serial, SERIAL_SIZE, "%s", udev_device_get_sysattr_value(nvme, "serial"));
> > + snprintf(pp->rev, SCSI_REV_SIZE, "%s", udev_device_get_sysattr_value(nvme, "firmware_rev"));
> > + snprintf(pp->wwid, WWID_SIZE, "%s", udev_device_get_sysattr_value(pp->udev, "wwid"));
>
> With your udev rules change, you shouldn't need to set the wwid here. It
> should just get dealt with by the get_uid call in pathinfo (or with
> the new uevent merging code, before multipathd ever calls pathinfo).
Oh right, you are correct. I can spin this with that removed.
next prev parent reply other threads:[~2017-02-21 21:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 21:19 [PATCH 1/2] Don't blacklist nvme Keith Busch
2017-02-14 21:19 ` [PATCH 2/2] Fill NVMe specific path info Keith Busch
2017-02-20 17:57 ` Benjamin Marzinski
2017-02-21 21:06 ` Keith Busch [this message]
2017-02-14 21:35 ` [PATCH 1/2] Don't blacklist nvme Bart Van Assche
2017-02-14 23:00 ` Keith Busch
2017-02-15 14:57 ` Christoph Hellwig
2017-02-15 17:24 ` Keith Busch
2017-02-16 1:58 ` Mike Snitzer
2017-02-16 2:01 ` Mike Snitzer
2017-02-16 2:35 ` Mike Snitzer
2017-02-15 14:56 ` Christoph Hellwig
2017-02-16 2:53 ` hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme] Mike Snitzer
2017-02-16 5:00 ` Bart Van Assche
2017-02-16 12:37 ` Mike Snitzer
2017-02-16 19:46 ` Bart Van Assche
2017-02-16 20:23 ` Mike Snitzer
2017-02-16 20:58 ` Bart Van Assche
2017-02-16 14:26 ` Christoph Hellwig
2017-02-16 15:13 ` Mike Snitzer
2017-02-16 17:38 ` Keith Busch
2017-02-16 17:37 ` Bart Van Assche
2017-02-16 18:07 ` Keith Busch
2017-02-16 18:21 ` Mike Snitzer
2017-02-16 20:40 ` Keith Busch
2017-02-17 9:04 ` [dm-devel] " hch
2017-02-17 14:43 ` Mike Snitzer
2017-02-16 18:05 ` Sagi Grimberg
2017-02-17 9:05 ` [dm-devel] " Christoph Hellwig
2017-02-17 14:37 ` Mike Snitzer
2017-02-17 9:33 ` [dm-devel] " Christoph Hellwig
2017-02-17 14:32 ` Mike Snitzer
2017-02-20 18:17 ` [PATCH 1/2] Don't blacklist nvme Benjamin Marzinski
2017-02-20 14:14 ` Mike Snitzer
2017-02-27 5:37 ` Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221210657.GA2453@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox