From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/4] dm mpath: don't return -EIO from dm_report_EIO
Date: Mon, 15 May 2017 14:41:08 -0400 [thread overview]
Message-ID: <20170515184108.GB6257@redhat.com> (raw)
In-Reply-To: <20170515152839.23375-3-hch@lst.de>
On Mon, May 15 2017 at 11:28am -0400,
Christoph Hellwig <hch@lst.de> wrote:
> Instead just turn the macro into a helper for the warning message.
> This removes an unessecary assignment in this patch, and will allow
> to fix a place where -EIO is the wrong error value in th next.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Something clearlyy got screwed up in my rebase. Because I specifically
recall casting the multipath_clone_and_map()'s !pgpath call with:
(void) dm_report_EIO(m);
Very weird. Anyway, thanks for catching these issues.
Mike
next prev parent reply other threads:[~2017-05-15 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 15:28 dm fixes for 4.12-rc Christoph Hellwig
2017-05-15 15:28 ` [PATCH 1/4] dm rq: add a missing break to map_request Christoph Hellwig
2017-05-15 18:25 ` Mike Snitzer
2017-05-15 15:28 ` [PATCH 2/4] dm mpath: don't return -EIO from dm_report_EIO Christoph Hellwig
2017-05-15 18:41 ` Mike Snitzer [this message]
2017-05-15 15:28 ` [PATCH 3/4] dm mpath: multipath_clone_and_map must not return -EIO Christoph Hellwig
2017-05-15 15:28 ` [PATCH 4/4] dm: fix REQ_RAHEAD handling Christoph Hellwig
2017-05-15 18:46 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515184108.GB6257@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox