From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Benjamin Marzinski" Subject: Re: [PATCH] libmultipath: update 3PARdata builtin config Date: Thu, 29 Jun 2017 09:57:31 -0500 Message-ID: <20170629145731.GR2940@octiron.msp.redhat.com> References: <1498503799-24026-1-git-send-email-bmarzins@redhat.com> <5d7143cd-4964-93ca-1e71-0119eb2a8ea1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5d7143cd-4964-93ca-1e71-0119eb2a8ea1@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Xose Vazquez Perez Cc: device-mapper development List-Id: dm-devel.ids On Wed, Jun 28, 2017 at 07:48:38PM +0200, Xose Vazquez Perez wrote: > On 06/26/2017 09:03 PM, Benjamin Marzinski wrote: > > > This updated config comes from hp. > > It would be nice to have more information. > Why and when is this needed? I assume the change to dev_loss_tmo is simply a preference issue. Like Netapp, they don't want their devices to get auto-removed when they go down. I also assume that in their internal testing, they hit cases where 5 seconds wasn't enough time to wait for some transient issue with the array to resolve. At any rate, I'm simply passing along their request, which seems like a perfectly reasonable one to me. -Ben > > > BTW: HPE 'MSA 205x' and 'StoreVirtual 3200'(LeftHand) are missing. > > > Signed-off-by: Benjamin Marzinski > > --- > > libmultipath/hwtable.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > > index 390d143..54bdcfc 100644 > > --- a/libmultipath/hwtable.c > > +++ b/libmultipath/hwtable.c > > @@ -49,6 +49,8 @@ static struct hwentry default_hw[] = { > > .hwhandler = "1 alua", > > .prio_name = PRIO_ALUA, > > .no_path_retry = 18, > > + .fast_io_fail = 10, > > + .dev_loss = MAX_DEV_LOSS_TMO, > > }, > > { > > /* RA8000 / ESA12000 */ > >