From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@redhat.com, Benjamin Marzinski <bmarzins@redhat.com>
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>,
Martin Wilck <mwilck@suse.com>
Subject: [RFC PATCH 05/16] multipath -u -i: change logic for find_multipaths
Date: Fri, 19 Jan 2018 01:29:05 +0100 [thread overview]
Message-ID: <20180119002916.10323-6-mwilck@suse.com> (raw)
In-Reply-To: <20180119002916.10323-1-mwilck@suse.com>
Previously, if find_multipaths was set, files listed in the wwids file
weren't set to be multipathed by "multipath -u -i" unless they also
met the "find_multpaths" criteria (at least two paths, or existing map with
this WWID). Now we classify all paths in the WWIDs file as multipath members.
The rationale for this patch is to match the logic that multipathd applies
when "-n" is not given.
---
multipath/main.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/multipath/main.c b/multipath/main.c
index 21cc45145dbb..b7e5cf46fe0f 100644
--- a/multipath/main.c
+++ b/multipath/main.c
@@ -423,16 +423,19 @@ configure (struct config *conf, enum mpath_cmds cmd,
* set, you need to actually check if there are two available
* paths to determine if this path should be multipathed. To
* do this, we put off the check until after discovering all
- * the paths */
- if (cmd == CMD_VALID_PATH &&
- (!conf->find_multipaths || !conf->ignore_wwids)) {
- if (conf->ignore_wwids ||
+ * the paths.
+ * Paths listed in the wwids file are always considered valid.
+ */
+ if (cmd == CMD_VALID_PATH) {
+ if ((!conf->find_multipaths && conf->ignore_wwids) ||
check_wwids_file(refwwid, 0) == 0)
r = 0;
-
- printf("%s %s a valid multipath device path\n",
- devpath, r == 0 ? "is" : "is not");
- goto out;
+ if (r == 0 ||
+ !conf->find_multipaths || !conf->ignore_wwids) {
+ printf("%s %s a valid multipath device path\n",
+ devpath, r == 0 ? "is" : "is not");
+ goto out;
+ }
}
}
--
2.15.1
next prev parent reply other threads:[~2018-01-19 0:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 0:29 [RFC PATCH 00/16] multipath path classification Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 01/16] Revert "multipath: ignore -i if find_multipaths is set" Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 02/16] Revert "multipathd: imply -n " Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 03/16] libmultipath: add mpvec param to should_multipath() Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 04/16] libmultipath: should_multipath: keep existing maps Martin Wilck
2018-01-19 16:06 ` Benjamin Marzinski
2018-01-19 0:29 ` Martin Wilck [this message]
2018-01-19 0:29 ` [RFC PATCH 06/16] libmultipath: let ignore_wwids be set in config file Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 07/16] multipathd: replace -n with !ignore_wwids Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 08/16] multipath.conf.5: document "ignore_wwids" Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 09/16] multipath.8: adapt documentation of '-i' Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 10/16] multipathd.8: document that '-n' is now ignored Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 11/16] multipath: common code path for CMD_VALID_PATH Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 12/16] multipath -u/-c: change output to environment/key format Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 13/16] multipath -u/-c: add "$DEV is maybe a valid path" Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 14/16] multipath.rules: find_multipaths+ignore_wwids logic Martin Wilck
2018-01-19 18:12 ` Benjamin Marzinski
2018-01-20 1:20 ` Martin Wilck
2018-01-21 3:21 ` Benjamin Marzinski
2018-01-22 21:56 ` Martin Wilck
2018-01-25 13:40 ` Benjamin Marzinski
2018-01-26 17:29 ` Martin Wilck
2018-01-29 22:28 ` Benjamin Marzinski
2018-01-30 13:07 ` Martin Wilck
2018-01-30 23:40 ` Benjamin Marzinski
2018-01-20 0:27 ` [FIX for 14/16] multipath.rules: set job properties for systemd-run correctly Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 15/16] libmultipath: trigger change uevent on new device creation Martin Wilck
2018-01-19 0:29 ` [RFC PATCH 16/16] libmultipath: trigger path uevent only when necessary Martin Wilck
2018-03-07 8:53 ` [RFC PATCH 00/16] multipath path classification Christophe Varoqui
2018-03-07 9:26 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119002916.10323-6-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).