Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 0/6] Various multipath-tools patches
Date: Tue, 6 Mar 2018 09:25:18 -0600	[thread overview]
Message-ID: <20180306152518.GO14513@octiron.msp.redhat.com> (raw)
In-Reply-To: <20180301192935.14643-1-bart.vanassche@wdc.com>

On Thu, Mar 01, 2018 at 11:29:29AM -0800, Bart Van Assche wrote:
> Hello Christophe,
> 
> This series contains the following patches:
> - Four patches address Coverity complaints.
> - One patch makes a function argument const.
> - One patch addresses a bug that I discovered while inspecting the multipath
>   command line tool output.
> 
> Please consider these patches for the multipath-tools project.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

For the set. Buy I agree with Martin that we should fold some of these
into his already posted patches.

-Ben

> 
> Thanks,
> 
> Bart.
> 
> Bart Van Assche (6):
>   multipathd/main.c: Fix indentation
>   libmultipath, alloc_path_with_pathinfo(): Ensure that pp->wwid is
>     '\0'-terminated
>   libmultipath, alloc_path_with_pathinfo(): Declare third argument const
>   kpartx: Improve reliability of find_loop_by_file()
>   libmultipath: Fix sgio_get_vpd()
>   Introduce the ibmultipath/unaligned.h header file
> 
>  kpartx/lopart.c                       |  7 ++++---
>  libmpathpersist/mpath_pr_ioctl.c      |  8 ++++----
>  libmultipath/checkers/hp_sw.c         |  4 ++--
>  libmultipath/discovery.c              | 22 +++++++++++---------
>  libmultipath/discovery.h              |  2 +-
>  libmultipath/prioritizers/alua_rtpg.c | 13 ++++++------
>  libmultipath/prioritizers/alua_spc3.h | 35 ++------------------------------
>  libmultipath/prioritizers/ontap.c     |  4 ++--
>  libmultipath/unaligned.h              | 38 +++++++++++++++++++++++++++++++++++
>  multipathd/main.c                     |  4 ++--
>  10 files changed, 74 insertions(+), 63 deletions(-)
>  create mode 100644 libmultipath/unaligned.h
> 
> -- 
> 2.16.2
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

  parent reply	other threads:[~2018-03-06 15:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 19:29 [PATCH 0/6] Various multipath-tools patches Bart Van Assche
2018-03-01 19:29 ` [PATCH 1/6] multipathd/main.c: Fix indentation Bart Van Assche
2018-03-05 16:09   ` Martin Wilck
2018-03-01 19:29 ` [PATCH 2/6] libmultipath, alloc_path_with_pathinfo(): Ensure that pp->wwid is '\0'-terminated Bart Van Assche
2018-03-05 16:11   ` Martin Wilck
2018-03-01 19:29 ` [PATCH 3/6] libmultipath, alloc_path_with_pathinfo(): Declare third argument const Bart Van Assche
2018-03-05 16:18   ` Martin Wilck
2018-03-05 16:21     ` Bart Van Assche
2018-03-01 19:29 ` [PATCH 4/6] kpartx: Improve reliability of find_loop_by_file() Bart Van Assche
2018-03-05 18:38   ` Martin Wilck
2018-03-01 19:29 ` [PATCH 5/6] libmultipath: Fix sgio_get_vpd() Bart Van Assche
2018-03-05 16:53   ` Martin Wilck
2018-03-05 17:09     ` Martin Wilck
2018-03-05 19:14       ` Martin Wilck
2018-03-05 19:18         ` Bart Van Assche
2018-03-05 20:47           ` Martin Wilck
2018-03-05 21:13             ` Bart Van Assche
2018-03-05 23:24               ` Martin Wilck
2018-03-05 23:35                 ` Martin Wilck
2018-03-01 19:29 ` [PATCH 6/6] Introduce the ibmultipath/unaligned.h header file Bart Van Assche
2018-03-05 17:18   ` Martin Wilck
2018-03-06 15:25 ` Benjamin Marzinski [this message]
2018-03-07  9:56   ` [PATCH 0/6] Various multipath-tools patches Christophe Varoqui
2018-03-08 20:39     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306152518.GO14513@octiron.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=bart.vanassche@wdc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox