From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH v2 0/5] Fixes for config file parsing
Date: Thu, 8 Mar 2018 00:26:15 +0100 [thread overview]
Message-ID: <20180307232620.15746-1-mwilck@suse.com> (raw)
This series was motivated by the real-world problem that a user couldn't
figure out how to write a blacklist entry for a device called '1.8" SSD'.
Fixing this for good turned out to be a little tricky, therefore I also
added a test suite.
Changes since v1:
- fixed a problem with parsing the command strings from cli handlers.
Martin Wilck (5):
tests: add unit tests for config file parser
libmultipath: config parser: don't strip whitepace between quotes
libmultipath: config parser: Allow '"' in strings
libmultipath: config parser: fix corner case for double quotes
multipath.conf(5): improve syntax documentation
libmultipath/parser.c | 60 ++++--
libmultipath/parser.h | 1 +
multipath/multipath.conf.5 | 17 ++
multipathd/cli.c | 2 +-
tests/Makefile | 2 +-
tests/globals.c | 1 +
tests/parser.c | 474 +++++++++++++++++++++++++++++++++++++++++++++
7 files changed, 540 insertions(+), 17 deletions(-)
create mode 100644 tests/parser.c
--
2.16.1
next reply other threads:[~2018-03-07 23:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 23:26 Martin Wilck [this message]
2018-03-07 23:26 ` [PATCH v2 1/5] tests: add unit tests for config file parser Martin Wilck
2018-03-07 23:26 ` [PATCH v2 2/5] libmultipath: config parser: don't strip whitepace between quotes Martin Wilck
2018-03-07 23:26 ` [PATCH v2 3/5] libmultipath: config parser: Allow '"' in strings Martin Wilck
2018-03-23 16:59 ` Xose Vazquez Perez
2018-03-23 17:40 ` Martin Wilck
2018-03-07 23:26 ` [PATCH v2 4/5] libmultipath: config parser: fix corner case for double quotes Martin Wilck
2018-03-07 23:26 ` [PATCH v2 5/5] multipath.conf(5): improve syntax documentation Martin Wilck
2018-03-14 17:41 ` [PATCH v2 0/5] Fixes for config file parsing Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307232620.15746-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox