From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Benjamin Marzinski" <bmarzins@redhat.com>
Subject: Re: [PATCH v2 01/20] Revert "multipath: ignore -i if
 find_multipaths is set"
Date: Fri, 23 Mar 2018 12:51:09 -0500
Message-ID: <20180323175109.GF3103@octiron.msp.redhat.com>
References: <20180319150155.5363-1-mwilck@suse.com>
	<20180319150155.5363-2-mwilck@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dm-devel-bounces@redhat.com>
Content-Disposition: inline
In-Reply-To: <20180319150155.5363-2-mwilck@suse.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
To: Martin Wilck <mwilck@suse.com>
Cc: dm-devel@redhat.com
List-Id: dm-devel.ids

On Mon, Mar 19, 2018 at 04:01:36PM +0100, Martin Wilck wrote:
> This reverts commit ffbb886a8a16cb063d669cd76a1e656fd3ec8c4b.
> 
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  multipath/main.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/multipath/main.c b/multipath/main.c
> index 716203eab56c..20f46acd924a 100644
> --- a/multipath/main.c
> +++ b/multipath/main.c
> @@ -776,16 +776,6 @@ main (int argc, char *argv[])
>  		}
>  	}
>  
> -	/*
> -	 * FIXME: new device detection with find_multipaths currently
> -	 * doesn't work reliably.
> -	 */
> -	if (cmd ==  CMD_VALID_PATH &&
> -	    conf->find_multipaths && conf->ignore_wwids) {
> -		condlog(2, "ignoring -i flag because find_multipath is set in multipath.conf");
> -		conf->ignore_wwids = 0;
> -	}
> -
>  	if (getuid() != 0) {
>  		fprintf(stderr, "need to be root\n");
>  		exit(1);
> -- 
> 2.16.1