From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH v3 00/10] libmpathpersist fixes and some more
Date: Sun, 24 Jun 2018 21:09:34 +0200 [thread overview]
Message-ID: <20180624190944.27158-1-mwilck@suse.com> (raw)
Hi Christophe,
this is v3 of my small set of libmpathpersist fixes. It's based
on your latest push. Sorry again for missing that.
Changes wrt v2:
- rebased to latest upstream (39ad8dc8)
- added another gcc 8.1 fix, and another small patch I hadn't
submitted yet
Changes wrt v1:
- introduce and use get_unaligned_be64 (Bart van Assche)
- add test for (get|put)_unaligned_bexx functions
Note: we have both the "unaligned" and the "beXY_to_cpu" APIs
now, for essentially the same purpose. I wonder if we should
settle on a single API instead. I am unsure if beXY_to_cpu() has
alignment issues on some architectures (I don't think there are
issues on our current main target platforms). If yes, I believe that
we'd be on the safe side using the "unaligned" API.
Anyway, that could be done in a follow-up patch.
Thanks,
Martin
Martin Wilck (10):
libmpathpersist: remove duplicate test in readfullstatus
libmpathpersist: fix typo in mpath_format_readfullstatus
libmpathpersist: fix stack overflow in mpath_format_readfullstatus()
libmultipath: add (get|put)_unaligned_be64
multipath-tools/tests: add tests for get_unaligned_beXX
libmpathpersist: fix byte swapping for big endian systems
(lib)mpathpersist: use O_RDONLY file descriptors
libmultipath: fix gcc 8.1 "truncated output" warnings
multipathd: fix buffer size in cli_getprkey()
libmultipath: avoid error messages from RDAC check
libmpathpersist/mpath_persist.c | 8 +--
libmpathpersist/mpath_pr_ioctl.c | 75 +++++++++----------------
libmultipath/propsel.c | 2 +
libmultipath/sysfs.c | 4 +-
libmultipath/unaligned.h | 16 ++++++
libmultipath/util.c | 4 +-
mpathpersist/main.c | 2 +-
multipathd/cli_handlers.c | 4 +-
tests/Makefile | 2 +-
tests/unaligned.c | 96 ++++++++++++++++++++++++++++++++
10 files changed, 150 insertions(+), 63 deletions(-)
create mode 100644 tests/unaligned.c
--
2.17.1
next reply other threads:[~2018-06-24 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 19:09 Martin Wilck [this message]
2018-06-24 19:09 ` [PATCH v3 01/10] libmpathpersist: remove duplicate test in readfullstatus Martin Wilck
2018-06-24 19:09 ` [PATCH v3 02/10] libmpathpersist: fix typo in mpath_format_readfullstatus Martin Wilck
2018-06-24 19:09 ` [PATCH v3 03/10] libmpathpersist: fix stack overflow in mpath_format_readfullstatus() Martin Wilck
2018-06-24 19:09 ` [PATCH v3 04/10] libmultipath: add (get|put)_unaligned_be64 Martin Wilck
2018-06-24 19:09 ` [PATCH v3 05/10] multipath-tools/tests: add tests for get_unaligned_beXX Martin Wilck
2018-06-24 19:09 ` [PATCH v3 06/10] libmpathpersist: fix byte swapping for big endian systems Martin Wilck
2018-06-24 19:09 ` [PATCH v3 07/10] (lib)mpathpersist: use O_RDONLY file descriptors Martin Wilck
2018-06-24 19:09 ` [PATCH v3 08/10] libmultipath: fix gcc 8.1 "truncated output" warnings Martin Wilck
2018-06-24 19:09 ` [PATCH v3 09/10] multipathd: fix buffer size in cli_getprkey() Martin Wilck
2018-06-24 19:09 ` [PATCH v3 10/10] libmultipath: avoid error messages from RDAC check Martin Wilck
2018-06-25 22:32 ` [PATCH v3 00/10] libmpathpersist fixes and some more Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624190944.27158-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox