From: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Huaisheng Ye <yehs2007-ytc+IHgoah0@public.gmane.org>
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
bart.vanassche-Sjgp3cTcYWE@public.gmane.org,
chengnt-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org,
colyli-l3A5Bk7waGM@public.gmane.org,
schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required
Date: Fri, 27 Jul 2018 15:33:33 -0400 [thread overview]
Message-ID: <20180727193333.GA23266@redhat.com> (raw)
In-Reply-To: <20180725162849.8320-6-yehs2007-ytc+IHgoah0@public.gmane.org>
On Wed, Jul 25 2018 at 12:28pm -0400,
Huaisheng Ye <yehs2007-ytc+IHgoah0@public.gmane.org> wrote:
> From: Huaisheng Ye <yehs1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org>
>
> Function persistent_memory_claim doesn't need to get local pointer
> dummy_addr from direct_access. Using NULL instead of having to pass
> in a useless local pointer that caller then just throw away.
>
> Suggested-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Huaisheng Ye <yehs1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org>
Acked-by: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2018-07-27 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 16:28 [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
[not found] ` <20180725162849.8320-1-yehs2007-ytc+IHgoah0@public.gmane.org>
2018-07-25 16:28 ` [PATCH v2 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 2/6] s390, dcssblk: " Huaisheng Ye
[not found] ` <20180725162849.8320-3-yehs2007-ytc+IHgoah0@public.gmane.org>
2018-07-28 4:07 ` [External] " Huaisheng HS1 Ye
[not found] ` <TY2PR03MB334328133134A67C87E5CC5C92290-9Zl3wwa4NoIz0wPdwKFbI682SN/2zMuYvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-30 5:14 ` Martin Schwidefsky
2018-07-25 16:28 ` [PATCH v2 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 4/6] dax/super: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr " Huaisheng Ye
[not found] ` <20180725162849.8320-6-yehs2007-ytc+IHgoah0@public.gmane.org>
2018-07-27 19:33 ` Mike Snitzer [this message]
2018-07-25 16:28 ` [PATCH v2 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-25 17:23 ` [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Ross Zwisler
2018-07-25 21:35 ` Dave Jiang
[not found] ` <3689520a-4a49-4e1f-6ee9-2ff4a9796b9f-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-07-26 1:29 ` [External] " Huaisheng HS1 Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727193333.GA23266@redhat.com \
--to=snitzer-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bart.vanassche-Sjgp3cTcYWE@public.gmane.org \
--cc=chengnt-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org \
--cc=colyli-l3A5Bk7waGM@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=yehs2007-ytc+IHgoah0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).