From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: [PATCH 3/5] libmultipath: pathinfo: skip hidden devices Date: Fri, 14 Sep 2018 14:51:01 +0200 Message-ID: <20180914125103.1154-3-mwilck@suse.com> References: <20180914125103.1154-1-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180914125103.1154-1-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christophe Varoqui Cc: dm-devel@redhat.com, Martin Wilck List-Id: dm-devel.ids Hidden block devices (in practice: members of nvme native multipath devices) can't be used by multipath anyway. Current multipath code (with default blacklisting) skips them, too, but emits a misleading "blacklisted: udev property missing" message. Signed-off-by: Martin Wilck --- libmultipath/discovery.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index 0b1855dd..11da64ba 100644 --- a/libmultipath/discovery.c +++ b/libmultipath/discovery.c @@ -1858,9 +1858,18 @@ int pathinfo(struct path *pp, struct config *conf, int mask) * limited by DI_BLACKLIST and occurs before this debug * message with the mask value. */ - if (pp->udev && (is_claimed_by_foreign(pp->udev) || - filter_property(conf, pp->udev) > 0)) - return PATHINFO_SKIPPED; + if (pp->udev) { + const char *hidden = + udev_device_get_sysattr_value(pp->udev, "hidden"); + + if (hidden && !strcmp(hidden, "1")) { + condlog(3, "%s: hidden", pp->dev); + return PATHINFO_SKIPPED; + } + if (is_claimed_by_foreign(pp->udev) || + filter_property(conf, pp->udev) > 0) + return PATHINFO_SKIPPED; + } if (filter_devnode(conf->blist_devnode, conf->elist_devnode, -- 2.18.0