From: Mike Snitzer <snitzer@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: dm-devel@redhat.com, kbuild-all@01.org
Subject: Re: [dm:for-next 2/3] drivers/md/dm-mpath.c:821:37: error: passing argument 1 of 'strcmp' from incompatible pointer type
Date: Mon, 17 Sep 2018 12:25:01 -0400 [thread overview]
Message-ID: <20180917162501.GA30382@redhat.com> (raw)
In-Reply-To: <201809180017.4eexn37t%fengguang.wu@intel.com>
On Mon, Sep 17 2018 at 12:16pm -0400,
kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> head: 9c01fc7e4f3b269a5550014c16ba2fa15b90fc45
> commit: 560e9814d061de1dce3328630846025d653dea7d [2/3] dm mpath: fix attached_handler_name leak and dangling hw_handler_name pointer
> config: x86_64-randconfig-x019-201837 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> git checkout 560e9814d061de1dce3328630846025d653dea7d
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/md/dm-mpath.c: In function 'setup_scsi_dh':
> >> drivers/md/dm-mpath.c:821:37: error: passing argument 1 of 'strcmp' from incompatible pointer type [-Werror=incompatible-pointer-types]
> if (m->hw_handler_name && strcmp(attached_handler_name, m->hw_handler_name)) {
> ^~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/bitmap.h:9:0,
> from include/linux/cpumask.h:12,
> from arch/x86/include/asm/cpumask.h:5,
> from arch/x86/include/asm/msr.h:11,
> from arch/x86/include/asm/processor.h:21,
> from arch/x86/include/asm/cpufeature.h:5,
> from arch/x86/include/asm/thread_info.h:53,
> from include/linux/thread_info.h:38,
> from arch/x86/include/asm/preempt.h:7,
> from include/linux/preempt.h:81,
> from include/linux/spinlock.h:51,
> from include/linux/wait.h:9,
> from include/linux/wait_bit.h:8,
> from include/linux/fs.h:6,
> from include/linux/highmem.h:5,
> from include/linux/bio.h:21,
> from include/linux/device-mapper.h:11,
> from drivers/md/dm-mpath.c:8:
> include/linux/string.h:44:12: note: expected 'const char *' but argument is of type 'char **'
> extern int strcmp(const char *,const char *);
> ^~~~~~
> drivers/md/dm-mpath.c: In function 'parse_path':
> >> drivers/md/dm-mpath.c:891:24: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> attached_handler_name = scsi_dh_attached_handler_name(q, GFP_KERNEL);
> ^
> cc1: some warnings being treated as errors
>
> vim +/strcmp +821 drivers/md/dm-mpath.c
Fixed, sorry for the noise.
prev parent reply other threads:[~2018-09-17 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 16:16 [dm:for-next 2/3] drivers/md/dm-mpath.c:821:37: error: passing argument 1 of 'strcmp' from incompatible pointer type kbuild test robot
2018-09-17 16:25 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917162501.GA30382@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox