From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v3 00/19] Misc Multipath patches
Date: Tue, 9 Oct 2018 11:13:06 -0500 [thread overview]
Message-ID: <20181009161306.GI3172@octiron.msp.redhat.com> (raw)
In-Reply-To: <CABr-GneyGf+Ks8ZkaFoReYuvSXvpfPwaXgg7eVFNoFCh84RwpA@mail.gmail.com>
On Sun, Oct 07, 2018 at 10:36:41AM +0200, Christophe Varoqui wrote:
I'll send a v4, hopefully today.
-Ben
> Hi Ben,
> this v3 patchset is ready for merge or do you plan a v4 ?
> Thanks,
> Christophe
> On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski
> <[1]bmarzins@redhat.com> wrote:
>
> This batch of patches is a resend of the non-merged pathes from my last
> set, along with 2 new ones. It would be really great if we could get
> a version bug after the outstanding commits go it.
>
> Patches 0001-0005 are a number of fixes to the tur checker.These are
> the ones that should get the most attention.
> Patches 0006-0017 are minor issues found by coverity.
> Not all of them are bugs that could actually occur in practice,
> but they are simple and hopefully non-controversial changes.
> Patches 0018-0019 are new and related to changing path wwids
>
> Changes in v3
> added patches 0018-0019
>
> Changes in v2
> 0002-libmultipath-fix-tur-checker-double-locking.patch now sets
> ct->devt when initially creating the tur_checker_context, while
> that structure is still only referenced by a local variable.
> After that, ct->devt is only ever read. This should remove any
> issues with it needing locking.
>
> Benjamin Marzinski (19):
> libmultipath: fix tur checker timeout
> libmultipath: fix tur checker double locking
> libmultipath: fix tur memory misuse
> libmultipath: cleanup tur locking
> libmultipath: fix tur checker timeout issue
> libmultipath: fix set_int error path
> libmultipath: fix length issues in get_vpd_sgio
> libmultipath: _install_keyword cleanup
> libmultipath: remove unused code
> libmultipath: fix memory issue in path_latency prio
> libmultipath: fix null dereference int alloc_path_group
> libmutipath: don't use malformed uevents
> multipath: fix max array size in print_cmd_valid
> multipathd: function return value tweaks
> multipathd: minor fixes
> multipathd: remove useless check and fix format
> multipathd: fix memory leak on error in configure
> libmultipath: Don't blank intialized paths
> libmultipath: Fixup updating paths
>
> libmultipath/checkers/tur.c | 168
> +++++++++++--------------------
> libmultipath/dict.c | 5 +-
> libmultipath/discovery.c | 18 ++--
> libmultipath/parser.c | 12 ++-
> libmultipath/print.c | 8 --
> libmultipath/prioritizers/path_latency.c | 3 +-
> libmultipath/structs.c | 2 +-
> libmultipath/uevent.c | 6 ++
> multipath/main.c | 2 +-
> multipathd/cli_handlers.c | 11 +-
> multipathd/main.c | 50 +++++----
> 11 files changed, 131 insertions(+), 154 deletions(-)
>
> --
> 2.7.4
>
> References
>
> Visible links
> 1. mailto:bmarzins@redhat.com
prev parent reply other threads:[~2018-10-09 16:13 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 23:05 [PATCH v3 00/19] Misc Multipath patches Benjamin Marzinski
2018-09-21 23:05 ` [PATCH v3 01/19] libmultipath: fix tur checker timeout Benjamin Marzinski
2018-10-01 19:51 ` Martin Wilck
2018-10-04 16:31 ` Benjamin Marzinski
2018-10-05 10:11 ` Martin Wilck
2018-10-05 17:02 ` Benjamin Marzinski
2018-10-05 19:23 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 02/19] libmultipath: fix tur checker double locking Benjamin Marzinski
2018-10-01 20:09 ` Martin Wilck
2018-10-01 20:44 ` Martin Wilck
2018-10-04 16:47 ` Benjamin Marzinski
2018-10-04 16:45 ` Benjamin Marzinski
2018-10-05 10:25 ` Martin Wilck
2018-10-05 17:10 ` Benjamin Marzinski
2018-10-05 19:07 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 03/19] libmultipath: fix tur memory misuse Benjamin Marzinski
2018-10-01 20:59 ` Martin Wilck
2018-10-02 7:48 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 04/19] libmultipath: cleanup tur locking Benjamin Marzinski
2018-10-01 21:08 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 05/19] libmultipath: fix tur checker timeout issue Benjamin Marzinski
2018-10-01 21:09 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 06/19] libmultipath: fix set_int error path Benjamin Marzinski
2018-10-01 21:17 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 07/19] libmultipath: fix length issues in get_vpd_sgio Benjamin Marzinski
2018-10-01 21:25 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 08/19] libmultipath: _install_keyword cleanup Benjamin Marzinski
2018-10-01 21:26 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 09/19] libmultipath: remove unused code Benjamin Marzinski
2018-10-01 21:28 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 10/19] libmultipath: fix memory issue in path_latency prio Benjamin Marzinski
2018-10-01 21:30 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 11/19] libmultipath: fix null dereference int alloc_path_group Benjamin Marzinski
2018-10-01 21:33 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 12/19] libmutipath: don't use malformed uevents Benjamin Marzinski
2018-10-01 21:31 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 13/19] multipath: fix max array size in print_cmd_valid Benjamin Marzinski
2018-10-01 21:35 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 14/19] multipathd: function return value tweaks Benjamin Marzinski
2018-10-01 21:37 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 15/19] multipathd: minor fixes Benjamin Marzinski
2018-10-01 21:38 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 16/19] multipathd: remove useless check and fix format Benjamin Marzinski
2018-10-01 21:40 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 17/19] multipathd: fix memory leak on error in configure Benjamin Marzinski
2018-10-01 21:42 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 18/19] libmultipath: Don't blank intialized paths Benjamin Marzinski
2018-10-01 22:00 ` Martin Wilck
2018-10-02 22:37 ` Martin Wilck
2018-10-05 19:38 ` Benjamin Marzinski
2018-10-08 9:41 ` Martin Wilck
2018-10-09 22:20 ` Benjamin Marzinski
2018-10-08 9:35 ` Martin Wilck
2018-09-21 23:05 ` [PATCH v3 19/19] libmultipath: Fixup updating paths Benjamin Marzinski
2018-10-01 22:30 ` Martin Wilck
2018-10-05 20:32 ` Benjamin Marzinski
2018-10-07 8:36 ` [PATCH v3 00/19] Misc Multipath patches Christophe Varoqui
2018-10-09 16:13 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009161306.GI3172@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox