From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Benjamin Marzinski" Subject: Re: [PATCH 07/21] libmultipath/checkers: hp_sw: use message id Date: Thu, 25 Oct 2018 15:58:57 -0500 Message-ID: <20181025205857.GP7100@octiron.msp.redhat.com> References: <20181011222707.3631-1-mwilck@suse.com> <20181011222707.3631-8-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181011222707.3631-8-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Martin Wilck Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Fri, Oct 12, 2018 at 12:26:53AM +0200, Martin Wilck wrote: Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > libmultipath/checkers/hp_sw.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/libmultipath/checkers/hp_sw.c b/libmultipath/checkers/hp_sw.c > index 0ad34a6b..d7f1018c 100644 > --- a/libmultipath/checkers/hp_sw.c > +++ b/libmultipath/checkers/hp_sw.c > @@ -27,10 +27,6 @@ > #define MX_ALLOC_LEN 255 > #define HEAVY_CHECK_COUNT 10 > > -#define MSG_HP_SW_UP "hp_sw checker reports path is up" > -#define MSG_HP_SW_DOWN "hp_sw checker reports path is down" > -#define MSG_HP_SW_GHOST "hp_sw checker reports path is ghost" > - > struct sw_checker_context { > void * dummy; > }; > @@ -128,14 +124,14 @@ int libcheck_check(struct checker * c) > char buff[MX_ALLOC_LEN]; > > if (0 != do_inq(c->fd, 0, 1, 0x80, buff, MX_ALLOC_LEN, 0, c->timeout)) { > - MSG(c, MSG_HP_SW_DOWN); > + c->msgid = CHECKER_MSGID_DOWN; > return PATH_DOWN; > - } > + }; > > if (do_tur(c->fd, c->timeout)) { > - MSG(c, MSG_HP_SW_GHOST); > + c->msgid = CHECKER_MSGID_GHOST; > return PATH_GHOST; > } > - MSG(c, MSG_HP_SW_UP); > + c->msgid = CHECKER_MSGID_UP; > return PATH_UP; > } > -- > 2.19.0