Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Martin Wilck <mwilck@suse.com>
Cc: dm-devel@redhat.com, Bart Van Assche <Bart.VanAssche@sandisk.com>
Subject: Re: [PATCH 2/7] multipathd: remove init_path_check_interval()
Date: Fri, 26 Oct 2018 13:53:59 -0500	[thread overview]
Message-ID: <20181026185359.GG7100@octiron.msp.redhat.com> (raw)
In-Reply-To: <20181023220552.1306-3-mwilck@suse.com>

On Wed, Oct 24, 2018 at 12:05:47AM +0200, Martin Wilck wrote:
> After "libmultipath: set pp->checkint in store_pathinfo()",
> pp-checkint should always be properly initialized, so this code
> is not needed any more.
> 

Reviewed-by: Benjamin Marzinsk <bmarzins@redhat.com>

> Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  multipathd/main.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index b8423d89..3464ebfa 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2131,19 +2131,6 @@ check_path (struct vectors * vecs, struct path * pp, int ticks)
>  	return 1;
>  }
>  
> -static void init_path_check_interval(struct vectors *vecs)
> -{
> -	struct config *conf;
> -	struct path *pp;
> -	unsigned int i;
> -
> -	vector_foreach_slot (vecs->pathvec, pp, i) {
> -		conf = get_multipath_config();
> -		pp->checkint = conf->checkint;
> -		put_multipath_config(conf);
> -	}
> -}
> -
>  static void *
>  checkerloop (void *ap)
>  {
> @@ -2727,7 +2714,6 @@ child (void * param)
>  	 */
>  	post_config_state(DAEMON_CONFIGURE);
>  
> -	init_path_check_interval(vecs);
>  
>  	if (poll_dmevents) {
>  		if (init_dmevent_waiter(vecs)) {
> -- 
> 2.19.1

  reply	other threads:[~2018-10-26 18:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 22:05 [PATCH 0/7] multipathd: make uxlsnr errors really fatal Martin Wilck
2018-10-23 22:05 ` [PATCH 1/7] libmultipath: set pp->checkint in store_pathinfo() Martin Wilck
2018-10-26 18:53   ` Benjamin Marzinski
2018-10-23 22:05 ` [PATCH 2/7] multipathd: remove init_path_check_interval() Martin Wilck
2018-10-26 18:53   ` Benjamin Marzinski [this message]
2018-10-23 22:05 ` [PATCH 3/7] multipathd: print error message if checkint is not initialized Martin Wilck
2018-10-26 18:55   ` Benjamin Marzinski
2018-10-23 22:05 ` [PATCH 4/7] multipathd: open client socket early Martin Wilck
2018-10-26 18:57   ` Benjamin Marzinski
2018-10-23 22:05 ` [PATCH 5/7] multipathd: set DAEMON_CONFIGURE from uxlsnr thread Martin Wilck
2018-10-26 20:19   ` Benjamin Marzinski
2018-10-30 16:55     ` Martin Wilck
2018-10-23 22:05 ` [PATCH 6/7] multipathd: make DAEMON_SHUTDOWN a terminal state Martin Wilck
2018-10-26 20:50   ` Benjamin Marzinski
2018-10-23 22:05 ` [PATCH 7/7] multipathd: only grab conf once for filter_path() Martin Wilck
2018-10-26 20:50   ` Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026185359.GG7100@octiron.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=dm-devel@redhat.com \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox