Linux Device Mapper development
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: Martin Wilck <mwilck@suse.com>, dm-devel@redhat.com
Subject: [PATCH v2 7/7] multipathd: only grab conf once for filter_path()
Date: Tue, 30 Oct 2018 22:22:49 +0100	[thread overview]
Message-ID: <20181030212249.31127-8-mwilck@suse.com> (raw)
In-Reply-To: <20181030212249.31127-1-mwilck@suse.com>

This saves a possibly large number of cleanup push/pop calls and
slightly improves readability.

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/multipathd/main.c b/multipathd/main.c
index 2f6aa3f0..6289718d 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2334,16 +2334,17 @@ configure (struct vectors * vecs)
 		goto fail;
 	}
 
+	conf = get_multipath_config();
+	pthread_cleanup_push(put_multipath_config, conf);
 	vector_foreach_slot (vecs->pathvec, pp, i){
-		conf = get_multipath_config();
-		pthread_cleanup_push(put_multipath_config, conf);
 		if (filter_path(conf, pp) > 0){
 			vector_del_slot(vecs->pathvec, i);
 			free_path(pp);
 			i--;
 		}
-		pthread_cleanup_pop(1);
 	}
+	pthread_cleanup_pop(1);
+
 	if (map_discovery(vecs)) {
 		condlog(0, "configure failed at map discovery");
 		goto fail;
-- 
2.19.1

      parent reply	other threads:[~2018-10-30 21:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 21:22 [PATCH v2 0/7] multipathd: make uxlsnr errors really fatal Martin Wilck
2018-10-30 21:22 ` [PATCH v2 1/7] libmultipath: set pp->checkint in store_pathinfo() Martin Wilck
2018-10-30 21:22 ` [PATCH v2 2/7] multipathd: remove init_path_check_interval() Martin Wilck
2018-10-30 21:22 ` [PATCH v2 3/7] multipathd: print error message if checkint is not initialized Martin Wilck
2018-10-30 21:22 ` [PATCH v2 4/7] multipathd: open client socket early Martin Wilck
2018-11-01 21:49   ` Benjamin Marzinski
2018-10-30 21:22 ` [PATCH v2 5/7] multipathd: set DAEMON_CONFIGURE from uxlsnr thread Martin Wilck
2018-10-30 21:22 ` [PATCH v2 6/7] multipathd: make DAEMON_SHUTDOWN a terminal state Martin Wilck
2018-10-30 21:22 ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030212249.31127-8-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox