From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH v3 2/7] multipathd: remove init_path_check_interval()
Date: Fri, 2 Nov 2018 13:23:57 +0100 [thread overview]
Message-ID: <20181102122402.31145-3-mwilck@suse.com> (raw)
In-Reply-To: <20181102122402.31145-1-mwilck@suse.com>
After "libmultipath: set pp->checkint in store_pathinfo()",
pp-checkint should always be properly initialized, so this code
is not needed any more.
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
multipathd/main.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index 958545a4..dfc10e54 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2133,19 +2133,6 @@ check_path (struct vectors * vecs, struct path * pp, int ticks)
return 1;
}
-static void init_path_check_interval(struct vectors *vecs)
-{
- struct config *conf;
- struct path *pp;
- unsigned int i;
-
- vector_foreach_slot (vecs->pathvec, pp, i) {
- conf = get_multipath_config();
- pp->checkint = conf->checkint;
- put_multipath_config(conf);
- }
-}
-
static void *
checkerloop (void *ap)
{
@@ -2729,7 +2716,6 @@ child (void * param)
*/
post_config_state(DAEMON_CONFIGURE);
- init_path_check_interval(vecs);
if (poll_dmevents) {
if (init_dmevent_waiter(vecs)) {
--
2.19.1
next prev parent reply other threads:[~2018-11-02 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 12:23 [PATCH v3 0/7] multipathd: make uxlsnr errors really fatal Martin Wilck
2018-11-02 12:23 ` [PATCH v3 1/7] libmultipath: set pp->checkint in store_pathinfo() Martin Wilck
2018-11-02 12:23 ` Martin Wilck [this message]
2018-11-02 12:23 ` [PATCH v3 3/7] multipathd: print error message if checkint is not initialized Martin Wilck
2018-11-02 12:23 ` [PATCH v3 4/7] multipathd: open client socket early Martin Wilck
2018-11-02 17:08 ` Benjamin Marzinski
2018-11-02 12:24 ` [PATCH v3 5/7] multipathd: set DAEMON_CONFIGURE from uxlsnr thread Martin Wilck
2018-11-02 12:24 ` [PATCH v3 6/7] multipathd: make DAEMON_SHUTDOWN a terminal state Martin Wilck
2018-11-02 12:24 ` [PATCH v3 7/7] multipathd: only grab conf once for filter_path() Martin Wilck
2018-11-14 7:38 ` [PATCH v3 0/7] multipathd: make uxlsnr errors really fatal Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102122402.31145-3-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox