From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [PATCH 2/2] multipathd: reset delay_wait_checks counter on failure
Date: Tue, 13 Nov 2018 22:30:52 +0100 [thread overview]
Message-ID: <20181113213052.2009-3-mwilck@suse.com> (raw)
In-Reply-To: <20181113213052.2009-1-mwilck@suse.com>
If path reinstantiation is delayed by delay_wait_checks, wait_checks
is counting down, the path fails during the delay phase, and then
comes up again, the wait_check counter starts counting down at the
same value where it previously stopped, which may be very low (even 1).
To avoid that, reset the counter to pp->delay_wait_checks if a failure
is encountered during the delay phase.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
multipathd/main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index 0dddddb3..622aa1ac 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2035,8 +2035,12 @@ check_path (struct vectors * vecs, struct path * pp, int ticks)
pp->wait_checks = pp->mpp->delay_wait_checks;
pp->watch_checks = 0;
}
- }else
+ } else {
fail_path(pp, 0);
+ if (pp->wait_checks > 0)
+ pp->wait_checks =
+ pp->mpp->delay_wait_checks;
+ }
/*
* cancel scheduled failback
--
2.19.1
next prev parent reply other threads:[~2018-11-13 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 21:30 [PATCH 0/2] two multipathd fixes Martin Wilck
2018-11-13 21:30 ` [PATCH 1/2] multipathd: fix irritating "minor number mismatch" message Martin Wilck
2018-11-13 21:30 ` Martin Wilck [this message]
2018-11-14 7:39 ` [PATCH 0/2] two multipathd fixes Christophe Varoqui
2018-11-14 18:45 ` multipath-tools: Bump version to 0.7.9 Xose Vazquez Perez
2018-11-14 18:55 ` Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113213052.2009-3-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox