From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: axboe@kernel.dk, Mike Snitzer <snitzer@redhat.com>,
John Dorminy <jdorminy@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: block: Fix a WRITE SAME BUG_ON
Date: Tue, 29 Jan 2019 00:52:26 -0800 [thread overview]
Message-ID: <20190129085226.GA25610@infradead.org> (raw)
In-Reply-To: <yq1lg34f4i7.fsf@oracle.com>
On Mon, Jan 28, 2019 at 11:54:08PM -0500, Martin K. Petersen wrote:
> That said, now that we have REQ_OP_WRITE_ZEROES (where the LBS is
> irrelevant due to the payload being the ZERO_PAGE), it may be worthwhile
> to remove REQ_OP_WRITE_SAME. I think drbd is the only user relying on a
> non-zero payload. The target code ends up manually iterating, if I
> remember correctly...
I had a series to remove it a while ago, but you wanted to keep it at
that point. I can resurrect it.
next prev parent reply other threads:[~2019-01-29 8:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 2:11 [v2] block: Fix a WRITE SAME BUG_ON Zhang Xiaoxu
2019-01-26 11:17 ` John Dorminy
2019-01-28 5:48 ` zhangxiaoxu (A)
2019-01-28 22:14 ` Mike Snitzer
2019-01-29 4:54 ` Martin K. Petersen
2019-01-29 8:52 ` Christoph Hellwig [this message]
2019-01-30 6:50 ` zhangxiaoxu (A)
2019-01-30 14:08 ` John Dorminy
2019-01-31 0:58 ` zhangxiaoxu (A)
2019-01-31 2:23 ` Martin K. Petersen
2019-01-31 10:39 ` Christoph Hellwig
2019-01-31 19:41 ` John Dorminy
2019-02-01 7:35 ` Christoph Hellwig
2019-02-01 14:09 ` John Dorminy
2019-02-01 16:03 ` Heinz Mauelshagen
2019-02-01 16:18 ` Christoph Hellwig
2019-02-12 3:11 ` zhangxiaoxu (A)
2019-02-14 2:31 ` Martin K. Petersen
2019-02-14 9:36 ` zhangxiaoxu (A)
2019-02-18 14:10 ` zhangxiaoxu (A)
2019-02-19 23:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129085226.GA25610@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=jdorminy@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox