From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: block: Fix a WRITE SAME BUG_ON Date: Thu, 31 Jan 2019 23:35:27 -0800 Message-ID: <20190201073527.GA14758@infradead.org> References: <20190125021107.4595-1-zhangxiaoxu5@huawei.com> <20190128221441.GA24102@redhat.com> <20190131103924.GA22503@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: John Dorminy Cc: axboe@kernel.dk, linux-block@vger.kernel.org, "Martin K. Petersen" , Mike Snitzer , Christoph Hellwig , dm-devel@redhat.com, Zhang Xiaoxu , Alasdair G Kergon List-Id: dm-devel.ids On Thu, Jan 31, 2019 at 02:41:52PM -0500, John Dorminy wrote: > > On Wed, Jan 30, 2019 at 09:08:50AM -0500, John Dorminy wrote: > > > (I use WRITE_SAME to fill devices with a particular pattern in order > > > to catch failures to initialize disk structures appropriately, > > > personally, but it's just for convenience/speed.) > > > > How do you use it? We don't have a user interface to generate > > REQ_OP_WRITE_SAME requests. > > A not-checked-in test module, similar to Zhang Xiaoxu's reproducer, > exposing a sysfs node to trigger filling a block device with a test > pattern. Any reason you don't just use SCSI/NVMe passthrough directly from userspace for that?