From: Mike Snitzer <snitzer@redhat.com>
To: John Dorminy <jdorminy@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Alasdair Kergon <agk@redhat.com>, Ming Lei <ming.lei@redhat.com>
Subject: Re: dm: rename max_io_len to io_boundary
Date: Thu, 21 Mar 2019 20:52:19 -0400 [thread overview]
Message-ID: <20190322005218.GA18625@redhat.com> (raw)
In-Reply-To: <CAMeeMh8Sed3ZN5wew6epsNJghzXgQ9Krsku-TSsLEGrHLACTnQ@mail.gmail.com>
On Thu, Mar 21 2019 at 6:57pm -0400,
John Dorminy <jdorminy@redhat.com> wrote:
> Perhaps this wording might be clearer?
>
> /* If non-zero, I/O submitted to a target will be split so as to not
> straddle any multiple of this length (in bytes) */
.max_io_len is a pretty well-worn DM target attribute.
I'd prefer to just take a patch with the above updated comment and leave
max_io_len as is. Not too interested in a flag day to rename it,
especially since it just becomes churn for every target, etc.
next prev parent reply other threads:[~2019-03-22 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 20:48 [PATCH] dm: rename max_io_len to io_boundary Mikulas Patocka
2019-03-21 22:57 ` John Dorminy
2019-03-22 0:52 ` Mike Snitzer [this message]
2019-03-22 13:21 ` Mikulas Patocka
2019-03-22 15:48 ` John Dorminy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322005218.GA18625@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jdorminy@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox