From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Subject: Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation Date: Thu, 8 Aug 2019 10:15:10 -0700 Message-ID: <20190808171508.GA201004@gmail.com> References: <20190807055022.15551-1-ard.biesheuvel@linaro.org> <20190808083059.GB5319@sol.localdomain> <67b4f0ee-b169-8af4-d7af-1c53a66ba587@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Pascal Van Leeuwen Cc: "herbert@gondor.apana.org.au" , "snitzer@redhat.com" , Ard Biesheuvel , "dm-devel@redhat.com" , "linux-crypto@vger.kernel.org" , Milan Broz , "agk@redhat.com" List-Id: dm-devel.ids T24gVGh1LCBBdWcgMDgsIDIwMTkgYXQgMDE6MjM6MTBQTSArMDAwMCwgUGFzY2FsIFZhbiBMZWV1 d2VuIHdyb3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IE1pbGFu IEJyb3ogPGdtYXp5bGFuZEBnbWFpbC5jb20+Cj4gPiBTZW50OiBUaHVyc2RheSwgQXVndXN0IDgs IDIwMTkgMjo1MyBQTQo+ID4gVG86IFBhc2NhbCBWYW4gTGVldXdlbiA8cHZhbmxlZXV3ZW5AdmVy aW1hdHJpeC5jb20+OyBFcmljIEJpZ2dlcnMgPGViaWdnZXJzQGtlcm5lbC5vcmc+Cj4gPiBDYzog QXJkIEJpZXNoZXV2ZWwgPGFyZC5iaWVzaGV1dmVsQGxpbmFyby5vcmc+OyBsaW51eC1jcnlwdG9A dmdlci5rZXJuZWwub3JnOwo+ID4gaGVyYmVydEBnb25kb3IuYXBhbmEub3JnLmF1OyBhZ2tAcmVk aGF0LmNvbTsgc25pdHplckByZWRoYXQuY29tOyBkbS1kZXZlbEByZWRoYXQuY29tCj4gPiBTdWJq ZWN0OiBSZTogW1JGQyBQQVRDSCB2Ml0gbWQvZG0tY3J5cHQgLSByZXVzZSBlYm9pdiBza2NpcGhl ciBmb3IgSVYgZ2VuZXJhdGlvbgo+ID4gCj4gPiBPbiAwOC8wOC8yMDE5IDExOjMxLCBQYXNjYWwg VmFuIExlZXV3ZW4gd3JvdGU6Cj4gPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4g Pj4gRnJvbTogRXJpYyBCaWdnZXJzIDxlYmlnZ2Vyc0BrZXJuZWwub3JnPgo+ID4gPj4gU2VudDog VGh1cnNkYXksIEF1Z3VzdCA4LCAyMDE5IDEwOjMxIEFNCj4gPiA+PiBUbzogUGFzY2FsIFZhbiBM ZWV1d2VuIDxwdmFubGVldXdlbkB2ZXJpbWF0cml4LmNvbT4KPiA+ID4+IENjOiBBcmQgQmllc2hl dXZlbCA8YXJkLmJpZXNoZXV2ZWxAbGluYXJvLm9yZz47IGxpbnV4LWNyeXB0b0B2Z2VyLmtlcm5l bC5vcmc7Cj4gPiA+PiBoZXJiZXJ0QGdvbmRvci5hcGFuYS5vcmcuYXU7IGFna0ByZWRoYXQuY29t OyBzbml0emVyQHJlZGhhdC5jb207IGRtLWRldmVsQHJlZGhhdC5jb207Cj4gPiA+PiBnbWF6eWxh bmRAZ21haWwuY29tCj4gPiA+PiBTdWJqZWN0OiBSZTogW1JGQyBQQVRDSCB2Ml0gbWQvZG0tY3J5 cHQgLSByZXVzZSBlYm9pdiBza2NpcGhlciBmb3IgSVYgZ2VuZXJhdGlvbgo+ID4gPj4KPiA+ID4+ IE9uIFdlZCwgQXVnIDA3LCAyMDE5IGF0IDA0OjE0OjIyUE0gKzAwMDAsIFBhc2NhbCBWYW4gTGVl dXdlbiB3cm90ZToKPiA+ID4+Pj4+PiBJbiB5b3VyIGNhc2UsIHdlIGFyZSBub3QgZGVhbGluZyB3 aXRoIGtub3duIHBsYWludGV4dCBhdHRhY2tzLAo+ID4gPj4+Pj4+Cj4gPiA+Pj4+PiBTaW5jZSB0 aGlzIGlzIFhUUywgd2hpY2ggaXMgdXNlZCBmb3IgZGlzayBlbmNyeXB0aW9uLCBJIHdvdWxkIGFy Z3VlCj4gPiA+Pj4+PiB3ZSBkbyEgRm9yIHRoZSB0d2VhayBlbmNyeXB0aW9uLCB0aGUgc2VjdG9y IG51bWJlciBpcyBrbm93biBwbGFpbnRleHQsCj4gPiA+Pj4+PiBzYW1lIGFzIGZvciBFQk9JVi4g QWxzbywgeW91IG1heSBiZSBhYmxlIHRvIGNvbnRyb2wgZGF0YSBiZWluZyB3cml0dGVuCj4gPiA+ Pj4+PiB0byB0aGUgZGlzayBlbmNyeXB0ZWQsIGVpdGhlciBkaXJlY3RseSBvciBpbmRpcmVjdGx5 Lgo+ID4gPj4+Pj4gT0ssIHBhcnQgb2YgdGhlIGRhdGEgaW50byB0aGUgQ1RTIGVuY3J5cHRpb24g d2lsbCBiZSBwcmV2aW91cyBjaXBoZXJ0ZXh0LAo+ID4gPj4+Pj4gYnV0IHRoYXQgbWF5IGJlIGp1 c3QgMSBieXRlIHdpdGggdGhlIHJlc3QgYmVpbmcgdGhlIGtub3duIHBsYWludGV4dC4KPiA+ID4+ Pj4+Cj4gPiA+Pj4+Cj4gPiA+Pj4+IFRoZSB0d2VhayBlbmNyeXB0aW9uIHVzZXMgYSBkZWRpY2F0 ZWQga2V5LCBzbyBsZWFraW5nIGl0IGRvZXMgbm90IGhhdmUKPiA+ID4+Pj4gdGhlIHNhbWUgaW1w YWN0IGFzIGl0IGRvZXMgaW4gdGhlIEVCT0lWIGNhc2UuCj4gPiA+Pj4+Cj4gPiA+Pj4gV2VsbCAu Li4geWVzIGFuZCBuby4gVGhlIHNwZWMgZGVmaW5lcyB0aGVtIGFzIHNlcGVyYXRlbHkgY29udHJv bGxhYmxlIC0KPiA+ID4+PiBkZXZpYXRpbmcgZnJvbSB0aGUgb3JpZ2luYWwgWEVYIGRlZmluaXRp b24gLSBidXQgaW4gbW9zdCBwcmFjdGljbGUgdXNlIGNhc2VzCj4gPiA+Pj4gSSd2ZSBzZWVuLCB0 aGUgc2FtZSBrZXkgaXMgdXNlZCBmb3IgYm90aCwgYXMgaGF2aW5nIDIga2V5cyBqdXN0IGluY3Jl YXNlcwo+ID4gPj4+IGtleSAgc3RvcmFnZSByZXF1aXJlbWVudHMgYW5kIGRvZXMgbm90IGFjdHVh bGx5IGltcHJvdmUgZWZmZWN0aXZlIHNlY3VyaXR5Cj4gPiA+Pj4gKG9mIHRoZSBhbGdvcml0aG0g aXRzZWxmLCBpbXBsZW1lbnRhdGlvbiBwZWN1bGlhcml0aWVzIGxpa2UgdGhpcyBvbmUgYXNpZGUK PiA+ID4+PiA6LSksIGFzICBYRVggaGFzIGJlZW4gcHJvdmVuIHNlY3VyZSB1c2luZyBhIHNpbmds ZSBrZXkuIEFuZCB0aGUgc2VjdXJpdHkKPiA+ID4+PiBwcm9vZiBmb3IgWFRTIGFjdHVhbGx5IGJ1 aWxkcyBvbiB0aGF0IHdoaWxlIHVzaW5nIDIga2V5cyBkZXZpYXRlcyBmcm9tIGl0Lgo+ID4gPj4+ Cj4gPiA+Pgo+ID4gPj4gVGhpcyBpcyBhIGNvbW1vbiBtaXNjb25jZXB0aW9uLiAgQWN0dWFsbHks IFhUUyBuZWVkcyAyIGRpc3RpbmN0IGtleXMgdG8gYmUgYQo+ID4gPj4gQ0NBLXNlY3VyZSB0d2Vh a2FibGUgYmxvY2sgY2lwaGVyLCBkdWUgdG8gYW5vdGhlciBzdWJ0bGUgZGlmZmVyZW5jZSBmcm9t IFhFWDoKPiA+ID4+IFhFWCAoYnkgd2hpY2ggSSByZWFsbHkgbWVhbiAiWEVYW0UsMl0iKSBidWls ZHMgdGhlIHNlcXVlbmNlIG9mIG1hc2tzIHN0YXJ0aW5nCj4gPiA+PiB3aXRoIHheMSwgd2hpbGUg WFRTIHN0YXJ0cyB3aXRoIHheMC4gIElmIG9ubHkgMSBrZXkgaXMgdXNlZCwgdGhlIGluY2x1c2lv biBvZgo+ID4gPj4gdGhlIDB0aCBwb3dlciBpbiBYVFMgYWxsb3dzIHRoZSBhdHRhY2sgZGVzY3Jp YmVkIGluIFNlY3Rpb24gNiBvZiB0aGUgWEVYIHBhcGVyCj4gPiA+PiAoaHR0cHM6Ly93ZWIuY3Mu dWNkYXZpcy5lZHUvfnJvZ2F3YXkvcGFwZXJzL29mZnNldHMucGRmKS4KPiA+ID4+Cj4gPiA+IElu dGVyZXN0aW5nIC4uLiBJJ20gbm90IGEgY3J5cHRvZ3JhcGhlciwganVzdCBhIGh1bWJsZSBIVyBl bmdpbmVlciBzcGVjaWFsaXplZAo+ID4gPiBpbiBpbXBsZW1lbnRpbmcgY3J5cHRvLiBJJ20gYmFz aW5nIG15IHZpZXdzIG1vc3RseSBvbiB0aGUgTGlza292L01pbmVtYXRzdQo+ID4gPiAiQ29tbWVu dHMgb24gWFRTIiwgd2hvIGFzc2VydCB0aGF0IHVzaW5nIDIga2V5cyBpbiBYVFMgd2FzIG1pc2d1 aWRlZC4KPiA+ID4gKGFuZCBJIG5ldmVyIHNhdyBhbnkgZm9sbG93LW9uIGNvbW1lbnRzIGFzc2Vy dGluZyB0aGF0IHRoaXMgdmlldyB3YXMgd3JvbmcgLi4uKQo+ID4gPiBPbiBub3QgYXZvaWRpbmcg aj0wIGluIHRoZSBYVFMgc3BlYyB0aGV5IGFjdHVhbGx5IGNvbW1lbnQ6Cj4gPiA+ICJUaGlzIGRp ZmZlcmVuY2UgaXMgc2lnbmlmaWNhbnQgaW4gc2VjdXJpdHksIGJ1dCBoYXMgbm8gaW1wYWN0IG9u IGVmZmVjdGl2ZW5lc3MKPiA+ID4gZm9yIHByYWN0aWNhbCBhcHBsaWNhdGlvbnMuIiwgd2hpY2gg SSByZWFkIGFzICJub3QgcmVsZXZhbnQgZm9yIG5vcm1hbCB1c2UiLgoKU2VlIHBhZ2UgNiBvZiAi Q29tbWVudHMgb24gWFRTIjoKCglOb3RlIHRoYXQgaiA9IDAgbXVzdCBiZSBleGNsdWRlZCwgYXMg ZigwLCB2KSA9IHYgZm9yIGFueSB2LCB3aGljaAoJaW1wbGllcyDPgSA9IDEuIE1vcmVvdmVyLCBp ZiBqID0gMCB3YXMgYWxsb3dlZCwgYSBzaW1wbGUgYXR0YWNrIGJhc2VkIG9uCgl0aGlzIGZhY3Qg ZXhpc3RlZCwgYXMgcG9pbnRlZCBvdXQgYnkgWzZdIGFuZCBbM10uIEhlbmNlIGlmIFhFWCBpcyB1 c2VkLAoJb25lIG11c3QgYmUgY2FyZWZ1bCB0byBhdm9pZCBqIGJlaW5nIDAuCgpUaGUgcGFydCB5 b3UgcXVvdGVkIGlzIG9ubHkgdGFsa2luZyBhYm91dCBYVFMgKmFzIHNwZWNpZmllZCosIGkuZS4g d2l0aCAyIGtleXMuCgo+ID4gPgo+ID4gPiBJbiBhbnkgY2FzZSwgaXQncyBmcmVxdWVudGx5ICp1 c2VkKiB3aXRoIGJvdGgga2V5cyBiZWluZyBlcXVhbCBmb3IgcGVyZm9ybWFuY2UKPiA+ID4gYW5k IGtleSBzdG9yYWdlIHJlYXNvbnMuCgpJdCdzIGJyb2tlbiwgc28gaXQncyBicm9rZW4uICBEb2Vz bid0IG1hdHRlciB3aG8gaXMgdXNpbmcgaXQuCgo+ID4gCj4gPiBUaGVyZSBpcyBhbHJlYWR5IGNo ZWNrIGluIGtlcm5lbCBmb3IgWFRTICJ3ZWFrIiBrZXlzICh0d2VhayBhbmQgZW5jcnlwdGlvbiBr ZXlzIG11c3Qgbm90IGJlCj4gPiB0aGUgc2FtZSkuCj4gPiAKPiA+IGh0dHBzOi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2lu Y2x1ZGUvY3J5cHRvL3h0cy5oIwo+ID4gbjI3Cj4gPiAKPiA+IEZvciBub3cgaXQgYXBwbGllcyBv bmx5IGluIEZJUFMgbW9kZS4uLiAoYW5kIGlmIEkgc2VlIGNvcnJlY3RseSBpdCBpcyBkdXBsaWNh dGVkIGluIGFsbAo+ID4gZHJpdmVycykuCj4gPiAKPiBJIG5ldmVyIGhhZCBhbnkgbmVlZCB0byBs b29rIGludG8gRklQUyBmb3IgWFRTIGJlZm9yZSwgYnV0IHRoaXMgYWN0dWFsbHkgYXBwZWFycwo+ IHRvIGJlIGFjY3VyYXRlLiBGSVBTIGluZGVlZCAqcmVxdWlyZXMgdGhpcyouIE11Y2ggdG8gbXkg c3VycHJpc2UsIEkgbWlnaHQgYWRkLgo+IFN0aWxsIGxvb2tpbmcgZm9yIHNvbWUgYWN0dWFsIHJh dGlvbmFsZSB0aGF0IGdvZXMgYmV5b25kIHN1Z2dlc3Rpb24gYW5kIGlubnVlbmRvIAo+IChhbmQg aXMgbm90IHRvbyBoZWF2eSBvbiB0aGUgbWF0aCA7LSkgdGhvdWdoLgoKQXMgSSBzYWlkLCB0aGUg YXR0YWNrIGlzIGV4cGxhaW5lZCBpbiB0aGUgb3JpZ2luYWwgWEVYIHBhcGVyLiAgQmFzaWNhbGx5 IHRoZQphZHZlcnNhcnkgY2FuIHN1Ym1pdCBhIGNob3NlbiBjaXBoZXJ0ZXh0IHF1ZXJ5IGZvciB0 aGUgZmlyc3QgYmxvY2sgb2Ygc2VjdG9yIDAKdG8gbGVhayB0aGUgZmlyc3QgIm1hc2siIG9mIHRo YXQgc2VjdG9yLCB0aGVuIHN1Ym1pdCBhIGNob3NlbiBwbGFpbnRleHQgb3IKY2lwaGVydGV4dCBx dWVyeSBmb3IgdGhlIHJlbWluZGVyIG9mIHRoZSBzZWN0b3Igc3VjaCB0aGF0IHRoZXkgY2FuIHBy ZWRpY3QgdGhlCm91dHB1dCB3aXRoIDEwMCUgY2VydGFpbnR5LiAgKFRoZSBzdGFuZGFyZCBzZWN1 cml0eSBtb2RlbCBmb3IgdHdlYWthYmxlIGJsb2NrCmNpcGhlcnMgc2F5cyB0aGUgb3V0cHV0IG11 c3QgYXBwZWFyIHJhbmRvbS4pCgotIEVyaWMKCi0tCmRtLWRldmVsIG1haWxpbmcgbGlzdApkbS1k ZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9k bS1kZXZlbA==