From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602BEC47082 for ; Tue, 8 Jun 2021 05:39:39 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C992F60FF4 for ; Tue, 8 Jun 2021 05:39:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C992F60FF4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-IYIskXHPM4ui7RU13fZc_Q-1; Tue, 08 Jun 2021 01:39:35 -0400 X-MC-Unique: IYIskXHPM4ui7RU13fZc_Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 945691020C36; Tue, 8 Jun 2021 05:39:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7C5219C66; Tue, 8 Jun 2021 05:39:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 835764EA6C; Tue, 8 Jun 2021 05:39:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1585dJPW024771 for ; Tue, 8 Jun 2021 01:39:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id AC28B6E1BF; Tue, 8 Jun 2021 05:39:19 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A72546E1BE for ; Tue, 8 Jun 2021 05:39:15 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D748380B915 for ; Tue, 8 Jun 2021 05:39:15 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-ruCpakqvN7Gr_GVk1bC9Qw-1; Tue, 08 Jun 2021 01:39:11 -0400 X-MC-Unique: ruCpakqvN7Gr_GVk1bC9Qw-1 Received: by verein.lst.de (Postfix, from userid 2407) id 2EEDF67373; Tue, 8 Jun 2021 07:39:06 +0200 (CEST) Date: Tue, 8 Jun 2021 07:39:05 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Message-ID: <20210608053905.GA14183@lst.de> References: <20210602065345.355274-1-hch@lst.de> <20210602065345.355274-21-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: Justin Sanders , Vignesh Raghavendra , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , "virtualization@lists.linux-foundation.org" , "dm-devel@redhat.com" , "Md. Haris Iqbal" , Miquel Raynal , Jack Wang , Christoph Hellwig , Tim Waugh , "linux-s390@vger.kernel.org" , Maxim Levitsky , Richard Weinberger , Christian Borntraeger , "xen-devel@lists.xenproject.org" , Ilya Dryomov , Vasily Gorbik , Alex Dubov , Konrad Rzeszutek Wilk , Heiko Carstens , Josef Bacik , Denis Efremov , "nbd@other.debian.org" , "linux-block@vger.kernel.org" , "ceph-devel@vger.kernel.org" , Jens Axboe , Geoff Levand , "linux-mmc@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [dm-devel] [PATCH 20/30] nullb: use blk_mq_alloc_disk X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 03, 2021 at 12:10:09AM +0000, Chaitanya Kulkarni wrote: > > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c > > index d8e098f1e5b5..74fb2ec63219 100644 > > --- a/drivers/block/null_blk/main.c > > +++ b/drivers/block/null_blk/main.c > > @@ -1851,13 +1851,12 @@ static int null_add_dev(struct nullb_device *dev) > > > > rv = -ENOMEM; > > Is above initialization needed ? It isn't strictly required any more. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel