From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4075EC433F5 for ; Thu, 18 Nov 2021 00:15:20 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF80561B72 for ; Thu, 18 Nov 2021 00:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF80561B72 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637194518; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BKUwfQ9TUD7Yv0cj5HxgRNZBBw29ys8J6f+sDl0uGBk=; b=e+qbeRi7fl5ad8nLtj7tYpZdsbdXnrAaKcsvMx34wtTfDuIg3xjHJweTfzNQ0QRZWU/qFU iGtvNuo0SCbTb1v8ATJFnhBYdCfOng68o6eJqVEA87G8gujjeaOy6ySr3My0uOYTB60AHj JVMuNvycRDR0KLT7dVnCe8w7Gz3A0hg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-hmUH5yVBM02gcvVpPZHXKw-1; Wed, 17 Nov 2021 19:15:15 -0500 X-MC-Unique: hmUH5yVBM02gcvVpPZHXKw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7E99102CB73; Thu, 18 Nov 2021 00:15:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCAB918A50; Thu, 18 Nov 2021 00:15:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 98E12180BAD2; Thu, 18 Nov 2021 00:15:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AI0AlM3007057 for ; Wed, 17 Nov 2021 19:10:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3CC0B60C4A; Thu, 18 Nov 2021 00:10:47 +0000 (UTC) Received: from octiron.msp.redhat.com (unknown [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4BD760C13; Thu, 18 Nov 2021 00:10:38 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 1AI0AaDS006070; Wed, 17 Nov 2021 18:10:37 -0600 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 1AI0AaH5006069; Wed, 17 Nov 2021 18:10:36 -0600 Date: Wed, 17 Nov 2021 18:10:35 -0600 From: Benjamin Marzinski To: lixiaokeng Message-ID: <20211118001035.GD19591@octiron.msp.redhat.com> References: <78637f61-851d-cf9d-d308-9c22396d2071@huawei.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: dm-devel@redhat.com Cc: linfeilong , dm-devel mailing list , Martin Wilck , "liuzhiqiang \(I\)" Subject: Re: [dm-devel] [PATCH 2/5] remove unnecessary memset X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 16, 2021 at 09:59:41PM +0800, lixiaokeng wrote: > MALLOC will set memory zero. memset is unnecessary. > Remove it. > > Signed-off-by: Lixiaokeng Reviewed-by: Benjamin Marzinski > --- > libmultipath/log.c | 1 - > multipathd/waiter.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/libmultipath/log.c b/libmultipath/log.c > index 10fa32cd..f41efb5b 100644 > --- a/libmultipath/log.c > +++ b/libmultipath/log.c > @@ -57,7 +57,6 @@ static int logarea_init (int size) > FREE(la); > return 1; > } > - memset(la->start, 0, size); > > la->empty = 1; > la->end = la->start + size; > diff --git a/multipathd/waiter.c b/multipathd/waiter.c > index bbe6c2a1..f74b395a 100644 > --- a/multipathd/waiter.c > +++ b/multipathd/waiter.c > @@ -33,7 +33,6 @@ static struct event_thread *alloc_waiter (void) > struct event_thread *wp; > > wp = (struct event_thread *)MALLOC(sizeof(struct event_thread)); > - memset(wp, 0, sizeof(struct event_thread)); > > return wp; > } > -- -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel